Date: Thu, 18 Dec 2014 09:15:33 -0700 From: Alan Somers <asomers@freebsd.org> To: Craig Rodrigues <rodrigc@freebsd.org> Cc: FreeBSD Net <freebsd-net@freebsd.org>, Adam McDougall <mcdouga9@egr.msu.edu>, "David P. Discher" <dpd@dpdtech.com> Subject: Re: FreeBSD 10-stable (r274577) LACP / IEEE 802.3ad with TP-Link TL-SG2008 - not working Message-ID: <CAOtMX2h01EuE5eE5%2BCKW4N44P5SK=pMudF0U4rd_ctxWD-USPw@mail.gmail.com> In-Reply-To: <CAG=rPVf19-WpR79xHEbavKLtHE-xpa_jCMQ1_uWyq0HUdpcE7Q@mail.gmail.com> References: <1A44709E-7D0C-4932-8A28-383EAC3F340B@dpdtech.com> <CAOtMX2gEGxTyXjitBu=pjkteocp1pSGxnb%2BWDb_jL3f0YNOjrg@mail.gmail.com> <9AE69175-92D9-49FA-A651-119C7046A1FA@dpdtech.com> <5480D8EF.9000804@egr.msu.edu> <3D993418-E632-44BA-8FE2-2F3F34188F20@dpdtech.com> <34276C9E-CAEF-4E3F-AA2A-568F2D3099EC@dpdtech.com> <CAOtMX2h3U-C9stM5qdix1HCqG=6rZD2GzKQw0t6Raoh6ToL3Og@mail.gmail.com> <2BCFC9D3-3B7D-421F-9FDA-0C4E1018F8F5@dpdtech.com> <CAOtMX2gfcRDWPmSAiNDuxpJC7bbKru90fyOqZe9WShpHL5LW0Q@mail.gmail.com> <A77F34EB-91DD-4FD8-B1BD-B1C9DB5AFE36@dpdtech.com> <CAG=rPVdHdJeBPMWGC5_zAO-e2Q0MXB3UNePXSqYXY6_OOeVX%2BQ@mail.gmail.com> <CAG=rPVf19-WpR79xHEbavKLtHE-xpa_jCMQ1_uWyq0HUdpcE7Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 17, 2014 at 10:11 PM, Craig Rodrigues <rodrigc@freebsd.org> wrote: > On Wed, Dec 17, 2014 at 9:08 PM, Craig Rodrigues <rodrigc@freebsd.org> > wrote: >> >> >> >> On Wed, Dec 17, 2014 at 5:36 PM, David P. Discher <dpd@dpdtech.com> wrote: >>> >>> >>> Yeah, Alan - will do ... if I decided to look into more. That is why I was >>> looking for spec on LACP. One side is doing it wrong. FreeBSD is looking >>> for a LACPDU of exactly sizeof ( struct lacpdu ) which is 124 bytes. The >>> TP-Link is sending a PDU of 128 bytes. I was hoping someone would know off >>> hand what the spec says, if the PDU "should be" or "must be". >>> >> >> >> I think you have stumbled across a valid problem in the FreeBSD code. I >> don't have access >> to 802.3ad-2000, but this might give you some clues: >> http://kb.juniper.net/InfoCenter/index?page=content&id=KB17674 >> >> I would also look at the source code of wireshark to be sure. wireshark >> has a sample capture of LACP packets here: >> >> http://wiki.wireshark.org/LinkAggregationControlProtocol >> >> > And here: > > http://www-01.ibm.com/support/docview.wss?uid=isg1VM64842 Good find, Craig. Also, I found the full LACPDU definition. It's in section 5.4.2.2, page 33, of the 802.1ax-2008 spec that I linked to. You can see the 4-byte FCS field at the end. Does your tp_link[4] field look like an FCS? If so, you need to figure out why it's propagating all the way up to the LACP level. -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2h01EuE5eE5%2BCKW4N44P5SK=pMudF0U4rd_ctxWD-USPw>