Date: Tue, 20 Sep 2011 09:50:27 -0700 From: David Thiel <lx@redundancy.redundancy.org> To: Sahil Tandon <sahil@tandon.net> Cc: "cvs-ports@FreeBSD.org" <cvs-ports@FreeBSD.org>, Eitan Adler <eadler@FreeBSD.org>, "ports-committers@FreeBSD.org" <ports-committers@FreeBSD.org> Subject: Re: cvs commit: ports/x11/iceauth Makefile distinfo ports/x11/libXcursor Makefile distinfo ports/x11/libXdmcp Makefile distinfo ports/x11/libxkbfile Makefile distinfo ports/x11/rstart Makefile distinfo ports/x11/smproxy Makefile distinfo ... Message-ID: <20110920165002.GG27781@redundancy.redundancy.org> In-Reply-To: <ED9D2BE6-47EF-4EEF-9A04-AC3F2D92491B@tandon.net> References: <201109200252.p8K2q1ma037870@repoman.freebsd.org> <20110920053052.GF27781@redundancy.redundancy.org> <ED9D2BE6-47EF-4EEF-9A04-AC3F2D92491B@tandon.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 20, 2011 at 08:44:00AM -0400, Sahil Tandon wrote: > > "x11" isn't a valid value for LICENSE, and setting it thus causes > > the build to fail for most of the ports touched by this commit. You > > can see the allowed values in bsd.licenses.db.mk - in this case, it > > should be "MIT". > > You are 100% correct. Bapt fixed this a little while ago. For the > record, this was completely my fault and an unforgivable oversight > during my review of eadler's commit. I'm sorry. No worries. To be fair, portlint doesn't actually seem to check this, and it's not documented in the porter's handbook, so proper use of LICENSE isn't exactly obvious.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110920165002.GG27781>