Date: Thu, 20 Aug 2015 13:24:16 -0600 From: Warner Losh <imp@bsdimp.com> To: Dimitry Andric <dim@freebsd.org> Cc: Oliver Pinter <oliver.pinter@hardenedbsd.org>, current@freebsd.org, imp@freebsd.org Subject: Re: 11-CURRENT build fail with base gcc Message-ID: <DF544DEB-7525-4497-A13D-F22DBF2FCF33@bsdimp.com> In-Reply-To: <30F511DD-2C7C-4252-8870-AC15B36FF36A@bsdimp.com> References: <CAPQ4ffuNzYQJHxuGKcJ%2BG5b47n-c7DjS6DJX9FrQFu9GGPrpbQ@mail.gmail.com> <B9AED518-76CC-4706-898F-65E72402ABD6@FreeBSD.org> <CAPQ4ffvEsRRhrLHoRhf4D3pUh%2BhnG_DBTHdQbdRNGbpT5Fk7kA@mail.gmail.com> <349EA432-E76D-4D1B-9383-E707967C806D@bsdimp.com> <BC306807-C29B-4629-AFFA-DA169541818B@FreeBSD.org> <30F511DD-2C7C-4252-8870-AC15B36FF36A@bsdimp.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Aug 20, 2015, at 1:21 PM, Warner Losh <imp@bsdimp.com> wrote: > > >> On Aug 20, 2015, at 10:32 AM, Dimitry Andric <dim@freebsd.org> wrote: >> >> On 20 Aug 2015, at 18:24, Warner Losh <imp@bsdimp.com> wrote: >>> >>>> On Aug 20, 2015, at 9:38 AM, Oliver Pinter <oliver.pinter@hardenedbsd.org> wrote: >> ... >>> >>> I think you are wrong about the cause. -mno-avx is bogusly listed unconditionally >>> in efi/Makefile.inc. I’m working on a patch now… >> >> Ah, this should be replaced with the recently introduced CFLAGS_NO_SIMD >> variable, then? > > Perhaps. Didn’t know this was a thing. That could use useful many places, though > there were two clang specific args I needed to move, not just the one that’s in this > flag. Maybe things are over-specified? > > Not sure I like bsd.cpu.mk growing more name-space pollution, especially stuff that > isn’t documented somewhere (bsd.cpu.mk is included from sys.mk, which is automaticallyed > globally included). All these hacks being stashed hither and yon are starting to get > very hard to keep straight for someone who looks at this code every day, let alone > somebody who invested CFLAGS_NO_SIMD independently for their code and finds > that breaks in an upgrade... Ah, it doesn’t include -mno-aes, but luckily that’s understood by both. Not sure why that’s needed, but is that the same ‘class’ or no? Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJV1ilgAAoJEGwc0Sh9sBEAqaIP/RrjqILB+YQdebf1FFvpl3/U r9yrGhVIiV6h4GwY/i4JZz2Ibmt9Q6mycCPTjRka5qEADgJI4QToIdl2eQmU0eQZ eT363CXxwWxOj9AZCoY8DoLjWrKPVT4Qp9kmjZrBOI4zMiSQeQFNBzP1ZmHrvANi Y5f3glbQkh3Dk66PA34trWN5WwWm9HSQF7ib8wBSuE/48x7OCoLDfe4lJiqk1NBp zHnP8burc4vzSoMER2rRji5HWR0llIXgv5s5LHhzQWjrYT5kkcXmdjW7LsJ7oi1a TweWZ8ogHzh4BVs6z8KO1JLF3ApHBjP5/GyvFdnw2R5POTOmeJodKs2k9xPc4GDV SBUIbo3vQzZqPKpzCbQmOKfMX51sqVbqNs/8W7wsTqZr420boKmR3jAc/Howo0fu BJ+1J4KeJwDxmPuHAt43DspDAj+WqRN7m5g1wXN02BkezKHIz6bmK7KMSGrTlEHz 1da6BBI+5bf4VXTjAvc/PdSSNOM0T9tL3qA3qdMUoaJFqkmmnZv0x/Ane/s2Ebq6 jpAjc99ug1IA31ab4KWXVsJ5DqwlVIcCPsU1A3Umhw5ffJexOwbOePKByhfl7ED9 KZWrsZ5IAh9ExgfCI48gHohE5PddTpU9HjjSoXQQ4PDHFF/kF/nl0/QkrtWhtVnu nptyDXDEsAILrRTVgqbv =k2n5 -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DF544DEB-7525-4497-A13D-F22DBF2FCF33>