Date: Tue, 31 Dec 2013 19:50:01 GMT From: John Marino <freebsd.contact@marino.st> To: freebsd-x11@FreeBSD.org Subject: Re: ports/184952: x11-servers/xorg-server: Slave port makefiles all have same error Message-ID: <201312311950.rBVJo18W054843@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/184952; it has been noted by GNATS. From: John Marino <freebsd.contact@marino.st> To: Niclas Zeising <zeising@freebsd.org> Cc: bug-followup@FreeBSD.org, freebsd@marino.st, kwm@freebsd.org, Baptiste Daroussin <bapt@freebsd.org> Subject: Re: ports/184952: x11-servers/xorg-server: Slave port makefiles all have same error Date: Tue, 31 Dec 2013 20:43:00 +0100 On 12/31/2013 19:23, Niclas Zeising wrote: > This breaks detection of WITH_NEW_XORG= and needs to be reverted. > Regards! Then your WITH_NEW_XORG detection is wrong. Having bsd.ports.options.mk loaded multiple times causes problems, such as applying the same patches multiple times (if patches are present). It was detected independently by myself and kwm. By the way, the "detection" broke DragonFly too because of the use of OSVERSION without OPSYS. I'd say the detection is what needs to be reverted. (DragonFly has /etc/defaults/make.conf so we put WITH_NEW_XORG defaults there) John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312311950.rBVJo18W054843>