Date: Fri, 25 Feb 2022 18:20:41 GMT From: Eric van Gyzen <vangyzen@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 1517b8d5a7f5 - main - vfs_unregister: fix error handling Message-ID: <202202251820.21PIKfXj001961@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by vangyzen: URL: https://cgit.FreeBSD.org/src/commit/?id=1517b8d5a7f58897200497811de1b18809c07d3e commit 1517b8d5a7f58897200497811de1b18809c07d3e Author: Marvin Ma <marvin.ma@dell.com> AuthorDate: 2022-02-25 15:34:33 +0000 Commit: Eric van Gyzen <vangyzen@FreeBSD.org> CommitDate: 2022-02-25 18:19:14 +0000 vfs_unregister: fix error handling Due to misplaced braces, an error from vfs_uninit() in the VFCF_SBDRY case was ignored. Reported by: Anton Rang <rang@acm.org> Reviewed by: Anton Rang <rang@acm.org>, markj MFC after: 1 week Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D34375 --- sys/kern/vfs_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/kern/vfs_init.c b/sys/kern/vfs_init.c index 112b4c76e575..612cc06a0db7 100644 --- a/sys/kern/vfs_init.c +++ b/sys/kern/vfs_init.c @@ -547,14 +547,13 @@ vfs_unregister(struct vfsconf *vfc) if (vfc->vfc_vfsops_sd->vfs_uninit != NULL) error = vfc->vfc_vfsops_sd->vfs_uninit(vfsp); } else { - if (vfc->vfc_vfsops->vfs_uninit != NULL) { + if (vfc->vfc_vfsops->vfs_uninit != NULL) error = vfc->vfc_vfsops->vfs_uninit(vfsp); } if (error != 0) { vfsconf_unlock(); return (error); } - } TAILQ_REMOVE(&vfsconf, vfsp, vfc_list); maxtypenum = VFS_GENERIC; TAILQ_FOREACH(vfsp, &vfsconf, vfc_list)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202202251820.21PIKfXj001961>