Date: Mon, 27 Apr 2009 02:22:00 -0400 From: Adam McDougall <mcdouga9@egr.msu.edu> To: Ben Kelly <ben@wanderview.com> Cc: freebsd-current@freebsd.org Subject: Re: [patch] zfs livelock and thread priorities Message-ID: <20090427062159.GS1012@egr.msu.edu> In-Reply-To: <FC83DB1E-6C08-4BD4-8BC9-437D714FEE9E@wanderview.com> References: <49C2CFF6.8070608@egr.msu.edu> <BDABA909-C2AE-4A55-869B-CA01BE778A82@wanderview.com> <ed91d4a80904131636u18c90474w7cdaa57bc7000e02@mail.gmail.com> <08D7DC2A-68BE-47B6-8D5D-5DE6B48F87E5@wanderview.com> <AC3C4C3F-40C6-4AF9-BAF3-2C4D1E444839@wanderview.com> <ed91d4a80904142135n429dea52o672abf51116fa707@mail.gmail.com> <ed91d4a80904241816r28531a04r2dc70fa8960d430e@mail.gmail.com> <bc2d970904241947r50576efbgc93164a9e4dd297d@mail.gmail.com> <ed91d4a80904242059n3642a40aud55df6d1b6a1695@mail.gmail.com> <FC83DB1E-6C08-4BD4-8BC9-437D714FEE9E@wanderview.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 25, 2009 at 01:49:33PM -0400, Ben Kelly wrote: On Apr 24, 2009, at 11:59 PM, Artem Belevich wrote: > Ah! Indeed. > >> va_list va; >> va_start(ap, fmt); >> va_copy(va, ap); >> vsnprintf(p2->p_comm, sizeof(p2->p_comm), fmt, va); >> vsnprintf(td->td_name, sizeof(td->td_name), fmt, ap); > > We also need va_end(va) to clear up after va_copy(); I've updated the patch to use va_copy(). Unfortunately I don't have an AMD64 machine to test on at the moment. However, I did look at other places in the kernel where va_copy() is used so I am hopeful I got it right. Thanks again for the help! - Ben I have the patch running on a amd64 desktop at home, so far so good and I'll run some portupgrades overnight. Assuming no huge problems with that, I have one or more systems at work I can try it with as well, as I have time.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090427062159.GS1012>