Date: Sat, 18 Jan 2014 07:26:40 +0800 From: Martin Wilke <miwi.fbsd@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r340073 - head/graphics/gphoto2 Message-ID: <CAFY%2ByE=wpKDF%2BcK5UG2VnTzFGdZOXzrzAe=0EyO=-foR7nj9rg@mail.gmail.com> In-Reply-To: <20140117185451.GA64598@FreeBSD.org> References: <201401171656.s0HGuFpw077232@svn.freebsd.org> <20140117185451.GA64598@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
http://www.freebsd.org/cgi/query-pr-summary.cgi?responsible=danfe thank you On Sat, Jan 18, 2014 at 2:54 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Fri, Jan 17, 2014 at 04:56:15PM +0000, Martin Wilke wrote: > > New Revision: 340073 > > URL: http://svnweb.freebsd.org/changeset/ports/340073 > > QAT: https://qat.redports.org/buildarchive/r340073/ > > (The following goes more to Kato and their ports sweatshop rather than > to Martin; just picking one commit of many.) > > > -USES= gmake pkgconfig > > USE_BZIP2= yes > > +USES= gmake pkgconfig > > This change is 1) gratuitous; 2) goes against most common practice of > placing USES above other USE_* knobs; 3) destroys my work of r322593. > > > +post-patch: > > + @${REINPLACE_CMD} -e \ > > + 's|-lpthread|-pthread|' \ > > + ${WRKSRC}/configure > > This REINPLACE_CMD statement perfectly fits one 80-char line, why break > it up? > > > post-install: > > - ${INSTALL_DATA} ${WRKSRC}/NEWS ${STAGEDIR}${DOCSDIR} > > + (cd ${WRKSRC} && ${INSTALL_DATA} NEWS ${STAGEDIR}${DOCSDIR}) > > Gratuitous; two commands instead of one; longer and less readable. Why? > > ./danfe >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFY%2ByE=wpKDF%2BcK5UG2VnTzFGdZOXzrzAe=0EyO=-foR7nj9rg>