Date: Wed, 29 Nov 2006 02:30:24 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Florent Thoumie <flz@FreeBSD.org>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ukbd.c usb_quirks.c usb_quirks.h usbdevs Message-ID: <20061128233024.GA38853@rambler-co.ru> In-Reply-To: <20061128231247.GB73497@tirith.brixandersen.dk> References: <200611282113.kASLD8vu090754@repoman.freebsd.org> <20061128220111.GA71168@tirith.brixandersen.dk> <20061128220529.GA38107@rambler-co.ru> <20061128222641.GA73497@tirith.brixandersen.dk> <20061128224915.GA38469@rambler-co.ru> <20061128231247.GB73497@tirith.brixandersen.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 29, 2006 at 12:12:47AM +0100, Henrik Brix Andersen wrote: > On Wed, Nov 29, 2006 at 01:49:15AM +0300, Ruslan Ermilov wrote: > > On Tue, Nov 28, 2006 at 11:26:41PM +0100, Henrik Brix Andersen wrote: > > > On Wed, Nov 29, 2006 at 01:05:29AM +0300, Ruslan Ermilov wrote: > > > > Why can't you just check for the defined constant? > > >=20 > > > To clarify: it is a run-time issue, not a compile-time issue. The > > > application will compile fine regardless of the above patch, but > > > without the above patch (and with ukbd/uhid loaded) the application > > > will fail to attach to the device. > > >=20 > > You want to build a port only when you know that the kernel has > > this fix? >=20 > That is my intention, yes. Otherwise end-users will likely be confused > as to why the application fails to detect their device. >=20 Though there's a way to set a make variable conditional on the result of running some external command (e.g., grep(1)), I agree that using __FreeBSD_version in this case is probably easier. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --RnlQjJ0d97Da+TV1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFbMaQqRfpzJluFF4RAjVZAKCZhreX54q7B9+Myh/oqW6LWLwq8QCfWYGN 6hau+W14C9QnRvt56gAddns= =fgrk -----END PGP SIGNATURE----- --RnlQjJ0d97Da+TV1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061128233024.GA38853>