Date: Thu, 30 Apr 2015 10:05:02 +0000 From: "andrew (Andrew Turner)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Commented On] D2377: Introduce ARM GICv3 support Message-ID: <43b0dd9a8a4242a753792fa581b54e90@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org> References: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
andrew added inline comments.
INLINE COMMENTS
sys/arm64/arm64/gic_v3.c:255 Why not do this something like:
#define GICD_ICENABLER(irq) (0x0180 + (((irq) >> 5) * 4))
#define GICD_INTR_MASK(irq) (1u << ((irq) % 32))
gic_r_write(sc, 4, GICD_ICENABLER(irq), GICD_INTR_MASK(irq));
sys/arm64/arm64/gic_v3.c:259 There should be a macro for PAGE_SIZE_64K
sys/arm64/arm64/gic_v3.c:300 1 second seems a long time to wait for a register to change.
sys/arm64/arm64/gic_v3.c:302 This is only needed in one case below.
sys/arm64/arm64/gic_v3.c:305 (Why the parentheses?)
sys/arm64/arm64/gic_v3.c:379 This could be
if (err)
return (err);
sys/arm64/arm64/gic_v3.c:388 To make this
return (0);
sys/arm64/arm64/gic_v3.c:504 What is special about `PAGE_SIZE_64K * 2`?
sys/arm64/arm64/gic_v3.c:509 This would normally be
} while ((typer & GICR_TYPER_LAST) == 0);
sys/arm64/arm64/gic_v3_reg.h:108 But the comment is `/* EL2 */`, I know el2 is not the name of a register
sys/arm64/arm64/gic_v3_var.h:45 It looks like there is extra whitespace here
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D2377
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43b0dd9a8a4242a753792fa581b54e90>