Date: Thu, 10 Feb 2011 22:35:06 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> To: arrowdodger <6yearold@gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. Message-ID: <20110210143506.GA66529@bonjour.sunpoet.net> In-Reply-To: <AANLkTikH51z9OERxbqQsNHsWyBkuKR_e09geAkRWjwPx@mail.gmail.com> References: <AANLkTin%2BCskJf8vP9iZwRvtC%2B66F%2BD6VPr6JbbO4v6pT@mail.gmail.com> <AANLkTimHUP5YvMrLuJ9NKET0=FyEO-M-5P8GJAJeU%2Bek@mail.gmail.com> <AANLkTi=uPh6PJiBcNWyMRnWK9Wf18R9eY91%2Be1CXRTgQ@mail.gmail.com> <AANLkTikwEoU=O5%2BncTPEOZMaMGFfoDLC_Q%2Bnr_NbWiec@mail.gmail.com> <AANLkTimx%2B6ybx9ULw8a=bfMZJ0tC1MKcg_QzRKsTTvjU@mail.gmail.com> <20110209161008.GD87684@bonjour.sunpoet.net> <AANLkTikH51z9OERxbqQsNHsWyBkuKR_e09geAkRWjwPx@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote: > I've updated port. The only thing left - setting dependency on py-gobject= by > USE_GNOME variable. > But if i run pkg_info -f on installed port, i see: >=20 > > Dependency: py26-gobject-2.26.0 > > dependency origin: devel/py-gobject > > > So, maybe this dependency is implicit and i should not care? Obviously USE_GNOME does not support devel/py-gobject now. All you can do is to use BUILD_DEPENDS/RUN_DEPENDS. Your pkg_info result indicates that you've installed gobject, but it means nothing to users of this port. The ports infrastructure generates dependency list according to the Makefile. If py-gobject is required, add it to the corresponding *_DEPENDS explicitly. Otherwise gobject will not be installed. > Updated port can be obtained here: > http://intara.org.ru/tortoisehg1.shar > or from attachment. Some comments: - PORTNAME can be different with the path. PORTNAME=3Dtortoisehg is OK. - We usually use "USE_PYTHON=3Dyes" - It would be better to keep patches in *-patch: targets. Move "${REINPLACE_CMD}" actions to post-patch:. - If this port does not need to run configure or so. Use do-configure: @${DO_NADA} Regards, --=20 Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org> 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110210143506.GA66529>