Date: Fri, 18 Jun 2021 19:58:29 +0200 From: Rainer Hurling <rhurlin@gwdg.de> To: Jan Beich <jbeich@FreeBSD.org> Cc: <ports-committers@FreeBSD.org>, <dev-commits-ports-all@FreeBSD.org>, <dev-commits-ports-main@FreeBSD.org> Subject: Re: git: aeb2d6000af2 - main - x11/kitty: Update to 0.21.1 Message-ID: <6da3c915-4441-95ff-2fc2-2544eb3ccf52@gwdg.de> In-Reply-To: <1r8z-map7-wny@FreeBSD.org> References: <202106181538.15IFcT8N077481__15247.3101437621$1624030723$gmane$org@gitrepo.freebsd.org> <1r8z-map7-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 18.06.21 um 17:52 schrieb Jan Beich: > Rainer Hurling <rhurlin@FreeBSD.org> writes: > >> The branch main has been updated by rhurlin: >> >> URL: https://cgit.FreeBSD.org/ports/commit/?id=aeb2d6000af2536c0e7f8be228cc267cefe76a09 >> >> commit aeb2d6000af2536c0e7f8be228cc267cefe76a09 >> Author: Rainer Hurling <rhurlin@FreeBSD.org> >> AuthorDate: 2021-06-18 15:33:34 +0000 >> Commit: Rainer Hurling <rhurlin@FreeBSD.org> >> CommitDate: 2021-06-18 15:33:34 +0000 >> >> x11/kitty: Update to 0.21.1 >> >> Fix a regression in the previous release that could cause >> a crash when changing layouts and mousing. >> >> Changelog: https://sw.kovidgoyal.net/kitty/changelog.html#id1 >> >> PR: 256678 >> Reported by: Alexis Praga <alexis.praga@free.fr> (maintainer) > > Why are you using "Reported by" when the patch was *submitted* by maintainer? > Same for the previous update (9176f36cbb6a). TIMESTAMP in distinfo matches. > > https://docs.freebsd.org/en/articles/committers-guide/#_include_appropriate_metadata_in_a_footer > Hi Jan, Thanks for pointing that out and apologies. I did not intend to disguise authorship in this way. In memory I still had that 'Submitted by:' should not be used anymore. I will use --author again in the future, as I have done several times before. BTW: 'Reported by:' also seems to be used by several others in commits that are based on a PR. This might have something to do with the fact that commits without authorship are otherwise not listed in the contributions graph of Github ... Regards, Rainer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6da3c915-4441-95ff-2fc2-2544eb3ccf52>