Date: Tue, 05 May 2026 15:05:32 +0000 From: Lexi Winter <ivy@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 5f901e157aaf - releng/15.1 - libifconfig: Skip bridge VLAN config for span members Message-ID: <69fa073c.1a07f.e12a530@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch releng/15.1 has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=5f901e157aafa6ed4550fe39dbc121f7668459b7 commit 5f901e157aafa6ed4550fe39dbc121f7668459b7 Author: Lexi Winter <ivy@FreeBSD.org> AuthorDate: 2026-04-29 03:11:20 +0000 Commit: Lexi Winter <ivy@FreeBSD.org> CommitDate: 2026-05-05 15:03:45 +0000 libifconfig: Skip bridge VLAN config for span members bridge(4) doesn't support BRDGGIFVLANSET for span members, which means if a span interface is configured, libifconfig will fail to fetch bridge members. Skip this for IFBIF_SPAN members. PR: 292634 MFC after: 3 days Reported by: Emrion <kmachine@free.fr> Reviewed by: pouria, zlei Approved by: re (cperciva) Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D56694 (cherry picked from commit 454322c08b8aa181939c8d920472f03cfd591032) (cherry picked from commit 0a919e2a9265b5cdaeb2c5d51c29791b4eb7335c) --- lib/libifconfig/libifconfig_bridge.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/libifconfig/libifconfig_bridge.c b/lib/libifconfig/libifconfig_bridge.c index 675bf5dd2ff5..2bb2952aeef2 100644 --- a/lib/libifconfig/libifconfig_bridge.c +++ b/lib/libifconfig/libifconfig_bridge.c @@ -139,6 +139,11 @@ ifconfig_bridge_get_bridge_status(ifconfig_handle_t *h, } for (size_t i = 0; i < bridge->inner.members_count; ++i) { struct ifbif_vlan_req vreq; + + /* Skip VLAN config for span members */ + if (bridge->inner.members[i].ifbr_ifsflags & IFBIF_SPAN) + continue; + memset(&vreq, 0, sizeof(vreq)); strlcpy(vreq.bv_ifname, bridge->inner.members[i].ifbr_ifsname, sizeof(vreq.bv_ifname));home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69fa073c.1a07f.e12a530>