Date: Fri, 4 Oct 2019 12:29:55 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: =?UTF-8?Q?Vin=c3=adcius_Zavam?= <egypcio@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r513663 - head/www/py-lektor Message-ID: <f3b2b8bb-da8a-4a75-2178-3fbe7c910c8e@FreeBSD.org> In-Reply-To: <201910031250.x93Coclr080961@repo.freebsd.org> References: <201910031250.x93Coclr080961@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/10/2019 10:50 pm, VinÃcius Zavam wrote: > Author: egypcio > Date: Thu Oct 3 12:50:38 2019 > New Revision: 513663 > URL: https://svnweb.freebsd.org/changeset/ports/513663 > > Log: > www/py-lektor: add devel/py-pip to RUN_DEPENDS > > - Makefile > based on upstream's setup.py, adding 'pip' to RUN_DEPENDS; > without 'pip' the lektor application wouldn't work as expected. > > https://github.com/lektor/lektor/blob/3.1.3/setup.py > > Modified: > head/www/py-lektor/Makefile > > Modified: head/www/py-lektor/Makefile > ============================================================================== > --- head/www/py-lektor/Makefile Thu Oct 3 11:18:02 2019 (r513662) > +++ head/www/py-lektor/Makefile Thu Oct 3 12:50:38 2019 (r513663) > @@ -2,6 +2,7 @@ > > PORTNAME= Lektor > PORTVERSION= 3.1.3 > +PORTREVISION= 1 > CATEGORIES= www devel python > MASTER_SITES= CHEESESHOP > PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} > @@ -20,7 +21,8 @@ RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}Jinja2>=2.4:devel/ > ${PYTHON_PKGNAMEPREFIX}Babel>=0:devel/py-babel@${PY_FLAVOR} \ > ${PYTHON_PKGNAMEPREFIX}setuptools>=0:devel/py-setuptools@${PY_FLAVOR} \ > ${PYTHON_PKGNAMEPREFIX}requests>=0:www/py-requests@${PY_FLAVOR} \ > - ${PYTHON_PKGNAMEPREFIX}inifile>=0.4:devel/py-inifile@${PY_FLAVOR} > + ${PYTHON_PKGNAMEPREFIX}inifile>=0.4:devel/py-inifile@${PY_FLAVOR} \ > + ${PYTHON_PKGNAMEPREFIX}pip>=0:devel/py-pip@${PY_FLAVOR} > > USES= python > USE_PYTHON= autoplist distutils > The only place pip is used is in WRKSRC/lektor/packages.py def download_and_install_package def install_local_package And pip should not be used to install dependencies pip should be removed from (patched out of) from install_requires and *_requires (extras_require, etc) used instead to describe additional/extra/non-compulsory dependencies) This should be sent/fixed upstream.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f3b2b8bb-da8a-4a75-2178-3fbe7c910c8e>