Date: Sat, 04 Apr 2020 11:30:53 +0200 From: "Kristof Provost" <kp@FreeBSD.org> To: FreeBSD-Current <freebsd-current@freebsd.org> Cc: status-updates@freebsdfoundation.org Subject: Bridge project update (Week of March 30th) Message-ID: <BAEEAC0E-80B9-4104-A5A4-3EA132B2C05D@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
Hi, A productive week! I’ve posted the main body of the patch for review: - https://reviews.freebsd.org/D24249 A preparatory patch. Mostly a mechanical substitution of LIST -> CK_LIST - https://reviews.freebsd.org/D24250 The main work. This changes the bridge data path to be mostly lockless (the only exception is when we have to add or update an rtnode. - https://reviews.freebsd.org/D24251 Another test case, for PR 216510. That bug was fixed more or less by accident during this work. I’ve also run performance testing with these patches, and I’m pretty happy with the results. The test shows an increase in throughput from 3.7Mpps to 18.6Mpps. The flame graphs also clearly show we’re no longer contending on the bridge mutex: - before: https://people.freebsd.org/~kp/if_bridge/unmodified.svg - after: https://people.freebsd.org/~kp/if_bridge/unicast.svg I’ll give D245250 another week or two for reviews. It’s a relatively small patch, considering, but it’s complex and important. I also intend to add another test case for a cleanup issue that’s since been fixed in D245250. Best regards, Kristof Provost From owner-freebsd-current@freebsd.org Sat Apr 4 20:17:59 2020 Return-Path: <owner-freebsd-current@freebsd.org> Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E37D92A1949 for <freebsd-current@mailman.nyi.freebsd.org>; Sat, 4 Apr 2020 20:17:59 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48vp5L06kvz3G4l for <freebsd-current@freebsd.org>; Sat, 4 Apr 2020 20:17:58 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from onlyone.not-for.work (onlyone.not-for.work [148.251.9.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: lev/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 6151A2DEAD for <freebsd-current@freebsd.org>; Sat, 4 Apr 2020 20:17:49 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from lion.home.serebryakov.spb.ru (unknown [IPv6:2001:470:923f:1:71e3:5f9e:ece1:e5b1]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.not-for.work (Postfix) with ESMTPSA id 858EE6516 for <freebsd-current@freebsd.org>; Sat, 4 Apr 2020 23:17:46 +0300 (MSK) Date: Sat, 4 Apr 2020 23:17:46 +0300 From: Lev Serebryakov <lev@FreeBSD.org> Reply-To: lev@FreeBSD.org Organization: FreeBSD Message-ID: <615764646.20200404231746@serebryakov.spb.ru> To: FreeBSD-Current <freebsd-current@freebsd.org> Subject: =?windows-1251?Q?CURRENT_crashes_if_loader.conf_contains_=ABnet.isr.dispatch=3D=22direct?= =?windows-1251?Q?=22=BB?= MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: base64 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current <freebsd-current.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>; List-Post: <mailto:freebsd-current@freebsd.org> List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, <mailto:freebsd-current-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sat, 04 Apr 2020 20:18:00 -0000 SGVsbG8gRnJlZUJTRC1DdXJyZW50LA0KDQogICBDVVJSRU5UIChhbmQ2NCwgcjM1OTYzMikg Y3Jhc2hlcyB2ZXJ5IGVhcmx5IG9uIGJvb3QgaWYNCmAvYm9vdC9sb2FkZXIuY29uZmAgY29u dGFpbnMgdGhpcyBsaW5lOg0KDQpuZXQuaXNyLmRpc3BhdGNoPSJkaXJlY3QiDQoNCiBTdGFj a3RyYWNlIChtYW51YWxseSB0cmFuc2NyaWJlZCBmcm9tIHBob3RvIG9mIHNjcmVlbiwgYXMg aXQgaXMgdmVyeSBlYXJseQ0Kc3RhZ2Ugb2YgYm9vdCwgc28gbm8gY3Jhc2hkdW1wIHBvc3Np YmxlKToNCg0KLi4uLg0KY2FsbHRyYXAoKQ0KLS0tIHRyYXAgMHhjDQptYWxsb2MoKQ0Kc3lz Y3RsX2hhbmRsZV9zdHJpbmcoKQ0Kc3lzY3RsX25ldGlzcl9kaXNwYXRjaF9wb2xpY3koKQ0K c3lzY3RsX3Jvb3RfaGFuZGxlcl9sb2NrZWQoKQ0Kc3lzY3RsX3JlZ2lzdGVyX29pZCgpDQpz eXNjdGxfcmVnaW9zdGVyX2FsbCgpDQptaV9zdGFydHVwKCkNCmJ0ZXh0KCkNCg0KICBJdCBp cyAxMDAlIHJlcHJvZHVjYWJsZSBmb3IgbWUsIHdpdGggR0VORVJJQyBrZXJuZWwuDQoNCiAg U29ycnksIGl0IGlzIHZlcnkgaGFyZCB0byBiaXNlY3QgYWNyb3NzIGNsYW5nMTAgaW1wb3J0 IGNvbW1pdCA6LSgNCg0KICAgQnV0IEkgc3VzcGVjdCwgaXQgaXMgdmVyeSBsb25nLXN0YW5k aW5nIHByb2JsZW0sIGF0IGxlYXN0IDMgb3IgNCBtb250aHMuDQoNCi0tIA0KQmVzdCByZWdh cmRzLA0KIExldiAgICAgICAgICAgICAgICAgICAgICAgICAgbWFpbHRvOmxldkBGcmVlQlNE Lm9yZw==
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BAEEAC0E-80B9-4104-A5A4-3EA132B2C05D>