Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Apr 2009 21:38:38 +1000 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Ed Schouten <ed@80386.nl>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, Steve Kargl <sgk@troutmask.apl.washington.edu>, svn-src-head@freebsd.org, Christoph Mallon <christoph.mallon@gmx.de>, Alexander Kabaev <kabaev@gmail.com>
Subject:   Re: svn commit: r190919 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include
Message-ID:  <20090413211354.G52297@delplex.bde.org>
In-Reply-To: <20090413110834.GC32098@hoeg.nl>
References:  <200904111401.n3BE1108088009@svn.freebsd.org> <20090411163528.GC46526@troutmask.apl.washington.edu> <20090411124335.0600a72f@kan.dnsalias.net> <49E1E01C.90704@gmx.de> <20090413110834.GC32098@hoeg.nl>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 13 Apr 2009, Ed Schouten wrote:

> Any comments on Christoph's patch before I commit it to SVN? It should
> at least make the headers more consistent than they are right now.

It makes the headers much less consistent, since (if it was the big
patch that I saw) it only changes 1 file in each of 2 arches, making
these files perfectly inconsistent with all nearby files and more
inconsistent with the corresponding files for other arches.

The patch to actually make things consistent (in hundreds more headers
and C files, just for __volatile and __inline) would be larger than
I want to read, especially in installments when diffing with old versions.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090413211354.G52297>