Date: Sun, 28 Oct 2012 22:03:32 +0100 From: Andre Oppermann <andre@freebsd.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r242254 - head/sys/netinet Message-ID: <508D9DA4.2000401@freebsd.org> In-Reply-To: <20121028200700.GL70741@FreeBSD.org> References: <201210281807.q9SI7Yxa069395@svn.freebsd.org> <20121028200700.GL70741@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28.10.2012 21:07, Gleb Smirnoff wrote:
> On Sun, Oct 28, 2012 at 06:07:34PM +0000, Andre Oppermann wrote:
> A> @@ -296,8 +297,8 @@ syncache_destroy(void)
> A> mtx_destroy(&sch->sch_mtx);
> A> }
> A>
> A> - KASSERT(V_tcp_syncache.cache_count == 0, ("%s: cache_count %d not 0",
> A> - __func__, V_tcp_syncache.cache_count));
> A> + KASSERT(uma_zone_get_cur(V_tcp_syncache.zone) == 0,
> A> + ("%s: cache_count not 0", __func__));
> A>
> A> /* Free the allocated global resources. */
> A> uma_zdestroy(V_tcp_syncache.zone);
>
> btw, keg_dtor() which is called in uma_zdestroy() printfs a warning
> (even on non-invariant kernel) if keg had items in it. So leak won't
> be unnoticed.
Thanks, didn't know that. I leave the KASSERT() in if you don't
mind to make it a bit more forceful than a printf that gets overlooked
too easily.
--
Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?508D9DA4.2000401>