Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 03 Oct 2010 12:54:26 +0200
From:      Miroslav Lachman <000.fbsd@quip.cz>
To:        Dominic Fandrey <kamikaze@bsdforen.de>
Cc:        David DEMELIER <demelier.david@gmail.com>, FreeBSD Ports <ports@freebsd.org>
Subject:   Re: OPTIONS
Message-ID:  <4CA860E2.2080402@quip.cz>
In-Reply-To: <4CA85617.7060503@bsdforen.de>
References:  <4C93AA31.5080202@DataIX.net>	<AANLkTik%2B1rvY4ZYgzHRjaX8PBfD1UqNCNeadHqg3KBfo@mail.gmail.com>	<20100918223933.GB85995@dragon.NUXI.org>	<AANLkTi=vPKpaPL9L=pQN9EdWdEN3sf1pos6uGtJU7ybV@mail.gmail.com>	<20101002002605.GA8018@dragon.NUXI.org>	<AANLkTinkasFFQ8ssbTSdbYUS%2BJ-tYMc1U3w9rkUCk9Gd@mail.gmail.com>	<4CA844E5.7060303@infracaninophile.co.uk>	<AANLkTimLqUaZMyDs-mhc-cQbASU%2B_1XqRjd=2=N%2BVSsR@mail.gmail.com> <4CA85617.7060503@bsdforen.de>

next in thread | previous in thread | raw e-mail | index | archive | help
Dominic Fandrey wrote:
> On 03/10/2010 11:45, David DEMELIER wrote:
>> 2010/10/3 Matthew Seaman<m.seaman@infracaninophile.co.uk>:
>> I don't want something complex, checkbox, textbox, radiobuttons is enough.
>
> Textbox is _very_ complex. Think of all the code you'd have to
> add to ports to check what was entered by the user.
> At the very least you have to verify that whatever was provided
> is valid. For the feature not to become annoying you'd have to
> be a lot more fuzzy and complex, though.

You don't need to. It is the same as if user put something wrong in to 
make.conf, ports.conf or even if somebody do:

cd /usr/ports/databases/mysql51-server
make WITH_CHARSET=UTF13 WITH_XCHARSET=1 WITH_COLLATION=true

All of them are invalid and not checked by ports framework, so if 
somebody implements textbox in to OPTIONS framework, the situation will 
not be worse! Situation will be better for those users not familiar with 
WITH_XXXX knobs.

Miroslav Lachman



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CA860E2.2080402>