Date: Sat, 05 Sep 2015 07:09:33 +0100 From: Rohit Grover <rgrover1@gmail.com> To: freebsd-drivers@freebsd.org Subject: Fwd: patch for atp driver Message-ID: <55EA871D.9000209@gmail.com> In-Reply-To: <55CA26E8.6070201@gmail.com> References: <55CA26E8.6070201@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------070104090007010904040707 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, Can someone help process a patch to the atp driver? See below. thanks, -------- Forwarded Message -------- Subject: patch for atp driver Date: Tue, 11 Aug 2015 17:46:32 +0100 From: Rohit Grover <rgrover1@gmail.com> To: Hans Petter Selasky <hps@bitfrost.no> Hello Hans, I'd like to submit a patch to fix an issue reported against the atp driver. Refer to https://github.com/rgrover/freebsd-atp/issues/1. This bug was introduced with revision *262417* <https://svnweb.freebsd.org/base?view=revision&revision=262417>. The original code can be seen at https://svnweb.freebsd.org/base/head/sys/dev/usb/input/atp.c?revision=233774&view=markup#l1788. Kevin, the person who reported the issue, has been driving the testing and validation effort. He confirms that the attached patch fixes the problem. Could you please review and merge this change? thanks, Rohit. --------------070104090007010904040707 Content-Type: text/plain; charset=UTF-8; name="diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="diff" ZGlmZiAtLWdpdCBhL2F0cC5jIGIvYXRwLmMKaW5kZXggODMyYzFlNi4uZjk3ZDY1OCAxMDA2 NDQKLS0tIGEvYXRwLmMKKysrIGIvYXRwLmMKQEAgLTk5NiwxNyArOTk2LDE2IEBAIGZnX2lu dGVycHJldF9zZW5zb3JfZGF0YShzdHJ1Y3QgYXRwX3NvZnRjICpzYywgdV9pbnQgZGF0YV9s ZW4pCiAJICogYmUgdXNlZCBhcyBwcmVzc3VyZSByZWFkaW5ncyBzdWJzZXF1ZW50bHkuCiAJ ICovCiAJc3RhdHVzX2JpdHMgPSBzYy0+c2Nfc2Vuc29yX2RhdGFbcGFyYW1zLT5kYXRhX2xl biAtIDFdOwotCWlmICgoKHBhcmFtcy0+cHJvdCA9PSBGR19UUkFDS1BBRF9UWVBFX0dFWVNF UjMpIHx8Ci0JICAgICAocGFyYW1zLT5wcm90ID09IEZHX1RSQUNLUEFEX1RZUEVfR0VZU0VS NCkpICAmJgorCWlmICgoKChwYXJhbXMtPnByb3QgPT0gRkdfVFJBQ0tQQURfVFlQRV9HRVlT RVIzKSB8fAorCSAgICAgIChwYXJhbXMtPnByb3QgPT0gRkdfVFJBQ0tQQURfVFlQRV9HRVlT RVI0KSkgJiYKKwkgICAgIChzdGF0dXNfYml0cyAmIEZHX1NUQVRVU19CQVNFX1VQREFURSkp IHx8CiAJICAgICgoc2MtPnNjX3N0YXRlICYgQVRQX1ZBTElEKSA9PSAwKSkgewotCQlpZiAo c3RhdHVzX2JpdHMgJiBGR19TVEFUVVNfQkFTRV9VUERBVEUpIHsKLQkJCW1lbWNweShzYy0+ c2NfYmFzZV94LCBzYy0+c2NfY3VyX3gsCi0JCQkgICAgcGFyYW1zLT5uX3hzZW5zb3JzICog c2l6ZW9mKCpzYy0+c2NfYmFzZV94KSk7Ci0JCQltZW1jcHkoc2MtPnNjX2Jhc2VfeSwgc2Mt PnNjX2N1cl95LAotCQkJICAgIHBhcmFtcy0+bl95c2Vuc29ycyAqIHNpemVvZigqc2MtPnNj X2Jhc2VfeSkpOwotCQkJc2MtPnNjX3N0YXRlIHw9IEFUUF9WQUxJRDsKLQkJCXJldHVybjsK LQkJfQorCSAgICBtZW1jcHkoc2MtPnNjX2Jhc2VfeCwgc2MtPnNjX2N1cl94LAorCSAgICAg ICAgICAgcGFyYW1zLT5uX3hzZW5zb3JzICogc2l6ZW9mKCpzYy0+c2NfYmFzZV94KSk7CisJ ICAgIG1lbWNweShzYy0+c2NfYmFzZV95LCBzYy0+c2NfY3VyX3ksCisJICAgICAgICAgICBw YXJhbXMtPm5feXNlbnNvcnMgKiBzaXplb2YoKnNjLT5zY19iYXNlX3kpKTsKKwkgICAgc2Mt PnNjX3N0YXRlIHw9IEFUUF9WQUxJRDsKKwkgICAgcmV0dXJuOwogCX0KIAogCS8qIEdldCBw cmVzc3VyZSByZWFkaW5ncyBhbmQgZGV0ZWN0IHAtc3BhbnMgZm9yIGJvdGggYXhlcy4gKi8K --------------070104090007010904040707--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55EA871D.9000209>