Date: Fri, 17 Aug 2018 09:25:32 -0600 From: Alan Somers <asomers@freebsd.org> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337736 - in head/sys: netinet netinet6 Message-ID: <CAOtMX2gWgKb4Yv3OS8KP9AfdGKQ2d4ZSB0p9CqW9tBt%2BdQvU0A@mail.gmail.com> In-Reply-To: <ef873364-625a-ca2d-6d2b-8b1d567df8c6@yandex.ru> References: <201808140754.w7E7sEFs018313@repo.freebsd.org> <CAOtMX2gzWCGBL80N7e1J1pLeBnPv6t18Bkw9vmobJv%2BkDwqcCw@mail.gmail.com> <ef873364-625a-ca2d-6d2b-8b1d567df8c6@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 17, 2018 at 7:31 AM, Andrey V. Elsukov <bu7cher@yandex.ru> wrote: > On 16.08.2018 21:34, Alan Somers wrote: > > On Tue, Aug 14, 2018 at 1:54 AM, Andrey V. Elsukov <ae@freebsd.org > > <mailto:ae@freebsd.org>> wrote: > > > > Author: ae > > Date: Tue Aug 14 07:54:14 2018 > > New Revision: 337736 > > URL: https://svnweb.freebsd.org/changeset/base/337736 > > <https://svnweb.freebsd.org/changeset/base/337736>; > > > > Log: > > Restore ability to send ICMP and ICMPv6 redirects. > > > > It was lost when tryforward appeared. Now ip[6]_tryforward will be > > enabled > > only when sending redirects for corresponding IP version is > > disabled via > > sysctl. Otherwise will be used default forwarding function. > > > > PR: 221137 > > > > This change broke the sys/netipsec/tunnel tests. I don't know if it's a > > limitation of the tests, or a genuine kernel bug, but I bisected the > > regression down to this change. Can you please fix it? > > > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/8630/ > testReport/sys.netipsec.tunnel/empty/v4/ > > I think it is because IPv4 tests use broadcast addresses in some places. > The attached patch fixes the test for me. > > -- > WBR, Andrey V. Elsukov > Hm, it certainly is weird to use broadcast addresses in this context. But why did that work before your commit and not after?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2gWgKb4Yv3OS8KP9AfdGKQ2d4ZSB0p9CqW9tBt%2BdQvU0A>