Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Sep 2017 05:28:40 +0000
From:      "ae (Andrey V. Elsukov)" <phabric-noreply@FreeBSD.org>
To:        freebsd-net@freebsd.org
Subject:   [Differential] D12457: Complete INADDR_HASH lock protection
Message-ID:  <50499bdc58fd1c85612a5ea34d36d14a@localhost.localdomain>
In-Reply-To: <differential-rev-PHID-DREV-em3ftishzefmzreicm43-req@FreeBSD.org>
References:  <differential-rev-PHID-DREV-em3ftishzefmzreicm43-req@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

ae added inline comments.

INLINE COMMENTS

> eugen_grosbein.net wrote in if_stf.c:383
> in_localip() may be better, I just wished to make the patch as clear as possible minizing changes for first revision.

Using in_localip() is preferred, because INADDR_HASH is protected with rmlock only in head/ and stable/11. So if you plan to merge this into stable/10, you will need to do direct commit.

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D12457

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: eugen_grosbein.net, ae, avg, mav, rwatson
Cc: bz, imp, freebsd-net-list


Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50499bdc58fd1c85612a5ea34d36d14a>