Date: Fri, 17 Aug 2018 10:28:37 -0500 From: Kyle Evans <kevans@freebsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337956 - in head: . bin/ls Message-ID: <CACNAnaHn%2BT27_LCvbVuUWZtjyVcgQEKOegmC=K3NEvyDiPi4NQ@mail.gmail.com> In-Reply-To: <CACNAnaEETxxJX-_S81cwe5R9TcpY6u8OaSdc7u8voLp%2Bi09qBA@mail.gmail.com> References: <201808170415.w7H4Fp7D046775@repo.freebsd.org> <201808171524.w7HFOdQi059798@pdx.rh.CN85.dnsmgr.net> <CACNAnaEETxxJX-_S81cwe5R9TcpY6u8OaSdc7u8voLp%2Bi09qBA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 17, 2018 at 10:26 AM, Kyle Evans <kevans@freebsd.org> wrote: > On Fri, Aug 17, 2018 at 10:24 AM, Rodney W. Grimes > <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: >> [ Charset UTF-8 unsupported, converting... ] >>> Author: kevans >>> Date: Fri Aug 17 04:15:51 2018 >>> New Revision: 337956 >>> URL: https://svnweb.freebsd.org/changeset/base/337956 >>> >>> Log: >>> ls(1): Add --color=when >>> >>> --color may be set to one of: 'auto', 'always', and 'never'. >>> >>> 'auto' is the default behavior- output colors only if -G or COLORTERM are >> >> Why different than coreutils ls? Default for coreutils is none. > > I guess this was worded poorly and you skipped both the review and > reading the diff... this is still contingent on environment variables > or -G being specified. > >>> set, and only if stdout is a tty. >>> >>> 'always' is a new behavior- output colors always. termcap(5) will be >>> consulted unless TERM is unset or not a recognized terminal, in which case >>> ls(1) will fall back to explicitly outputting ANSI escape sequences. >>> >>> 'never' to turn off any environment variable and -G usage. >> Why different than core utils? Coreutils uses none. > > I guess this was worded poorly and you skipped both the review and > reading the diff... this is still contingent on environment variables > or -G being specified. > ... copy-paste-o. The version of coreutils ls(1) that I have uses 'never' for this. There is no valid 'none' value.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHn%2BT27_LCvbVuUWZtjyVcgQEKOegmC=K3NEvyDiPi4NQ>