Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Feb 2024 10:44:39 +0000
From:      Andrew Turner <andrew@fubar.geek.nz>
To:        John Baldwin <jhb@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: 5bda26333a8e - main - gpiobus: Use bus_generic_rman_*
Message-ID:  <BF6822E4-C1F7-4998-AEFC-CA5301B170BC@fubar.geek.nz>
In-Reply-To: <202402142252.41EMqcLK086071@gitrepo.freebsd.org>
References:  <202402142252.41EMqcLK086071@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help


> On 14 Feb 2024, at 22:52, John Baldwin <jhb@freebsd.org> wrote:
>=20
> The branch main has been updated by jhb:
>=20
> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3D5bda26333a8ebf34190e3a9124895e6a=
18e58e93
>=20
> commit 5bda26333a8ebf34190e3a9124895e6a18e58e93
> Author:     John Baldwin <jhb@FreeBSD.org>
> AuthorDate: 2024-02-14 22:07:32 +0000
> Commit:     John Baldwin <jhb@FreeBSD.org>
> CommitDate: 2024-02-14 22:07:32 +0000
>=20
>    gpiobus: Use bus_generic_rman_*
>=20
>    Reviewed by:    imp
>    Differential Revision:  https://reviews.freebsd.org/D43887
> ---
> sys/dev/gpio/gpiobus.c | 57 =
+++++++++++++++++---------------------------------
> 1 file changed, 19 insertions(+), 38 deletions(-)
>=20
> diff --git a/sys/dev/gpio/gpiobus.c b/sys/dev/gpio/gpiobus.c
> index 99d3114d51da..6d739597b759 100644
> --- a/sys/dev/gpio/gpiobus.c
> +++ b/sys/dev/gpio/gpiobus.c
> @@ -809,20 +809,29 @@ gpiobus_write_ivar(device_t dev, device_t child, =
int which, uintptr_t value)
>         return (0);
> }
>=20
> +static struct rman *
> +gpiobus_get_rman(device_t bus, int type, u_int flags)

This is unused now. It looks like it=E2=80=99s missing =
"DEVMETHOD(bus_get_rman, gpiobus_get_rman)=E2=80=9D.

Andrew




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BF6822E4-C1F7-4998-AEFC-CA5301B170BC>