Date: Sat, 26 Nov 2011 21:03:46 -0500 (EST) From: Rick Macklem <rmacklem@uoguelph.ca> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: freebsd-fs@FreeBSD.org Subject: Re: NFS corruption in recent HEAD. Message-ID: <1798569802.431412.1322359425997.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <20111126165823.GD8794@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
Pawel Jakub Dawidek wrote:
> Hi.
>
> I'm booting machine over the network using new NFS client and I'm
> getting those warnings on boot:
>
> /etc/rc.subr: 666: Syntax error: "(" unexpected (expecting ";;")
>
> I inspected the /etc/rc.subr file on the client and here is the
> problem.
>
> At offset 16384 the file on the client contains data from offset 32768
> from the server. It contains exactly 7599 bytes from the wrong place
> at
> this offset. All next bytes up to offset 32768 are all zeros.
>
> So the data is identical for ranges <0-16384) and <32768-40367) (to
> the
> end of the file).
>
> Then range <16384-23983) contains data from <32768-40367) and
> <23984-32768) is all zeros. Probably if file would be bigger there
> will
> be no zeros, but more data from wrong block.
>
> It seems that the client is asking for third block where it should ask
> for second block (or the server is providing wrong block).
>
> Server is running '8.2-STABLE #17: Wed Sep 28 10:30:02 EDT 2011'.
>
> BTW. When I copy the file on the client using cp(1), the copy is not
> corrupted (cp(1) is using mmap(2)?). But when I do
> 'cat /etc/rc.subr > /foo' the corruptions is visible in new file too.
>
Oh, and maybe you could try reverting r227543 in the client (assuming
the client is post-r227543). Maybe that file's vnode type isn't set to
VREG early in the diskless booting and needs the ncl_flush() for some
reason.
I don't actually have a bug that needs r227543 to fix it. It just seemed
incorrect to flush non-VREG files (particularily VDIR). As such, reverting
it wouldn't be a big deal.
rick
> --
> Pawel Jakub Dawidek http://www.wheelsystems.com
> FreeBSD committer http://www.FreeBSD.org
> Am I Evil? Yes, I Am! http://yomoli.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1798569802.431412.1322359425997.JavaMail.root>