Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Apr 2026 15:29:11 +0000
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: c57d2b6f97d2 - stable/15 - rtld: Use a helper variable to simplify a few lines
Message-ID:  <69eb8c47.33ab8.402787f5@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/15 has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=c57d2b6f97d2b8c2dc67ab053f6bf1e006792309

commit c57d2b6f97d2b8c2dc67ab053f6bf1e006792309
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2026-01-15 18:23:42 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2026-04-24 15:26:38 +0000

    rtld: Use a helper variable to simplify a few lines
    
    Reviewed by:    kib
    Sponsored by:   AFRL, DARPA
    Differential Revision:  https://reviews.freebsd.org/D54507
    
    (cherry picked from commit 6d6bf4a892d6be84ec59fce5419eab616bcabb40)
---
 libexec/rtld-elf/rtld.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/libexec/rtld-elf/rtld.c b/libexec/rtld-elf/rtld.c
index 10b84246d4ce..8ae0685b02d9 100644
--- a/libexec/rtld-elf/rtld.c
+++ b/libexec/rtld-elf/rtld.c
@@ -5560,7 +5560,7 @@ allocate_tls(Obj_Entry *objs, void *oldtcb, size_t tcbsize, size_t tcbalign)
 	char *addr;
 	size_t i;
 	size_t extra_size, maxalign, post_size, pre_size, tls_block_size;
-	size_t tls_init_align, tls_init_offset;
+	size_t tls_init_align, tls_init_offset, tls_bss_offset;
 
 	if (oldtcb != NULL && tcbsize == TLS_TCB_SIZE)
 		return (oldtcb);
@@ -5618,11 +5618,10 @@ allocate_tls(Obj_Entry *objs, void *oldtcb, size_t tcbsize, size_t tcbalign)
 				    obj->tlsinitsize);
 			}
 			if (obj->tlssize > obj->tlsinitsize) {
-				memset(addr + tls_init_offset +
-				    obj->tlsinitsize,
-				    0,
-				    obj->tlssize - obj->tlsinitsize -
-					tls_init_offset);
+				tls_bss_offset = tls_init_offset +
+				    obj->tlsinitsize;
+				memset(addr + tls_bss_offset, 0,
+				    obj->tlssize - tls_bss_offset);
 			}
 			dtv->dtv_slots[obj->tlsindex - 1].dtvs_tls = addr;
 		}


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69eb8c47.33ab8.402787f5>