Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 8 May 2014 12:27:24 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r265672 - stable/9/sys/geom
Message-ID:  <201405081227.s48CRO9Z090418@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Thu May  8 12:27:24 2014
New Revision: 265672
URL: http://svnweb.freebsd.org/changeset/base/265672

Log:
  MFC r256606:
  Move g_io_deliver() out of the lock, as required for direct dispatch.
  Move g_destroy_bio() out too to reduce lock scope even more.

Modified:
  stable/9/sys/geom/geom_disk.c
Directory Properties:
  stable/9/   (props changed)
  stable/9/sys/   (props changed)

Modified: stable/9/sys/geom/geom_disk.c
==============================================================================
--- stable/9/sys/geom/geom_disk.c	Thu May  8 12:26:08 2014	(r265671)
+++ stable/9/sys/geom/geom_disk.c	Thu May  8 12:27:24 2014	(r265672)
@@ -249,13 +249,14 @@ g_disk_done(struct bio *bp)
 	bp2->bio_completed += bp->bio_completed;
 	if ((bp->bio_cmd & (BIO_READ|BIO_WRITE|BIO_DELETE)) != 0)
 		devstat_end_transaction_bio_bt(sc->dp->d_devstat, bp, &now);
-	g_destroy_bio(bp);
 	bp2->bio_inbed++;
 	if (bp2->bio_children == bp2->bio_inbed) {
+		mtx_unlock(&sc->done_mtx);
 		bp2->bio_resid = bp2->bio_bcount - bp2->bio_completed;
 		g_io_deliver(bp2, bp2->bio_error);
-	}
-	mtx_unlock(&sc->done_mtx);
+	} else
+		mtx_unlock(&sc->done_mtx);
+	g_destroy_bio(bp);
 }
 
 static int



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201405081227.s48CRO9Z090418>