Date: Mon, 20 Jan 2020 00:46:34 +0000 From: <Shichun.Ma@dell.com> To: <hps@selasky.org>, <freebsd-usb@freebsd.org> Cc: <Jason_YH_Yang@wistron.com> Subject: Re: USB keyboard/mouse wake up from S3 Message-ID: <1579481192594.378@Dell.com> In-Reply-To: <ce7a1eea-ca93-8344-e077-ef7ce68d6498@selasky.org> References: <1578625588784.46788@Dell.com> <47257477-bace-a9c5-69f5-7a0eb7af3947@selasky.org> <1578648297338.92657@Dell.com> <685f991f-6cb6-3f27-65d8-38181e4cfa8e@selasky.org> <1579231397567.62223@Dell.com> <a96a122f-6736-8af0-621f-e70b799593ed@selasky.org>, <ce7a1eea-ca93-8344-e077-ef7ce68d6498@selasky.org>
index | next in thread | previous in thread | raw e-mail
Hi HPS, Sorry, but I just have Intel SOC which only has XHCI integrated, I just tested with Intel's Gemini Lake SOC, and I can further test it with DELL OptiPlex later. I agree with your idea that preserves old behavior by default. Thanks & Regards, Shichun Ma Software Engineer Dell | Cloud Client Computing office +86 10 82862579, Mobile +86 13241851528 shichun_ma@dell.com ________________________________________ From: Hans Petter Selasky <hps@selasky.org> Sent: Friday, January 17, 2020 9:57 PM To: Ma, Horse; freebsd-usb@freebsd.org Cc: Jason_YH_Yang@wistron.com Subject: Re: USB keyboard/mouse wake up from S3 [EXTERNAL EMAIL] On 2020-01-17 10:41, Hans Petter Selasky wrote: > On 2020-01-17 04:23, Shichun.Ma@dell.com wrote: >> >> HPS, >> >> Here is my patch to enable USB wakeup under XHCI, I tested USB >> mouse/keyboard can wake up system from S3. >> > > Hi, > > Patches look OK, with some minor nits. > > Have you thought about adding EHCI/OHCI/UHCI to the wakeup matrix aswell? > > How many different computers and CPU architectures has this code been > tested with? > Also I want you to add a sysctl, hw.usb.no_wakeup, which if set, preserves the old behaviour. Thank you! --HPShelp
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1579481192594.378>