Date: Mon, 20 Jan 2020 00:46:34 +0000 From: <Shichun.Ma@dell.com> To: <hps@selasky.org>, <freebsd-usb@freebsd.org> Cc: <Jason_YH_Yang@wistron.com> Subject: Re: USB keyboard/mouse wake up from S3 Message-ID: <1579481192594.378@Dell.com> In-Reply-To: <ce7a1eea-ca93-8344-e077-ef7ce68d6498@selasky.org> References: <1578625588784.46788@Dell.com> <47257477-bace-a9c5-69f5-7a0eb7af3947@selasky.org> <1578648297338.92657@Dell.com> <685f991f-6cb6-3f27-65d8-38181e4cfa8e@selasky.org> <1579231397567.62223@Dell.com> <a96a122f-6736-8af0-621f-e70b799593ed@selasky.org>, <ce7a1eea-ca93-8344-e077-ef7ce68d6498@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi HPS,=0A= Sorry, but I just have Intel SOC which only has XHCI integrated, =0A= I just tested with Intel's Gemini Lake SOC, and I can further test it with= DELL OptiPlex later.=0A= I agree with your idea that preserves old behavior by default.=0A= =0A= Thanks & Regards,=0A= =0A= Shichun Ma=0A= Software Engineer=0A= Dell | Cloud Client Computing=0A= office +86 10 82862579, Mobile +86 13241851528=0A= shichun_ma@dell.com=0A= =0A= =0A= =0A= ________________________________________=0A= From: Hans Petter Selasky <hps@selasky.org>=0A= Sent: Friday, January 17, 2020 9:57 PM=0A= To: Ma, Horse; freebsd-usb@freebsd.org=0A= Cc: Jason_YH_Yang@wistron.com=0A= Subject: Re: USB keyboard/mouse wake up from S3=0A= =0A= [EXTERNAL EMAIL]=0A= =0A= On 2020-01-17 10:41, Hans Petter Selasky wrote:=0A= > On 2020-01-17 04:23, Shichun.Ma@dell.com wrote:=0A= >>=0A= >> HPS,=0A= >>=0A= >> Here is my patch to enable USB wakeup under XHCI, I tested USB=0A= >> mouse/keyboard can wake up system from S3.=0A= >>=0A= >=0A= > Hi,=0A= >=0A= > Patches look OK, with some minor nits.=0A= >=0A= > Have you thought about adding EHCI/OHCI/UHCI to the wakeup matrix aswell?= =0A= >=0A= > How many different computers and CPU architectures has this code been=0A= > tested with?=0A= >=0A= =0A= Also I want you to add a sysctl, hw.usb.no_wakeup, which if set,=0A= preserves the old behaviour.=0A= =0A= Thank you!=0A= =0A= --HPS=0A= =0A=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1579481192594.378>