Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Jan 2011 01:11:06 +0000 (UTC)
From:      Rick Macklem <rmacklem@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r217494 - stable/8/sys/fs/nfsserver
Message-ID:  <201101170111.p0H1B6wM083375@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rmacklem
Date: Mon Jan 17 01:11:06 2011
New Revision: 217494
URL: http://svn.freebsd.org/changeset/base/217494

Log:
  MFC: r216898
  Fix the experimental NFS server so that it doesn't leak
  a reference count on the directory when creating device
  special files.

Modified:
  stable/8/sys/fs/nfsserver/nfs_nfsdport.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)

Modified: stable/8/sys/fs/nfsserver/nfs_nfsdport.c
==============================================================================
--- stable/8/sys/fs/nfsserver/nfs_nfsdport.c	Mon Jan 17 00:59:04 2011	(r217493)
+++ stable/8/sys/fs/nfsserver/nfs_nfsdport.c	Mon Jan 17 01:11:06 2011	(r217494)
@@ -857,8 +857,7 @@ nfsvno_mknod(struct nameidata *ndp, stru
 		    &ndp->ni_cnd, &nvap->na_vattr);
 		vput(ndp->ni_dvp);
 		nfsvno_relpathbuf(ndp);
-		if (error)
-			vrele(ndp->ni_startdir);
+		vrele(ndp->ni_startdir);
 		/*
 		 * Since VOP_MKNOD returns the ni_vp, I can't
 		 * see any reason to do the lookup.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101170111.p0H1B6wM083375>