Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Feb 2010 19:44:44 +0000 (UTC)
From:      Juli Mallett <jmallett@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r204429 - user/jmallett/octeon/sys/mips/mips
Message-ID:  <201002271944.o1RJii6F055467@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jmallett
Date: Sat Feb 27 19:44:44 2010
New Revision: 204429
URL: http://svn.freebsd.org/changeset/base/204429

Log:
  Make hackish check for whether something is a kernel address more like right
  by not comparing signed quantities.

Modified:
  user/jmallett/octeon/sys/mips/mips/db_trace.c

Modified: user/jmallett/octeon/sys/mips/mips/db_trace.c
==============================================================================
--- user/jmallett/octeon/sys/mips/mips/db_trace.c	Sat Feb 27 19:43:14 2010	(r204428)
+++ user/jmallett/octeon/sys/mips/mips/db_trace.c	Sat Feb 27 19:44:44 2010	(r204429)
@@ -140,7 +140,7 @@ loop:
 	}
 	/* check for bad SP: could foul up next frame */
 	/*XXX MIPS64 bad: this hard-coded SP is lame */
-	if (sp & 3 || sp < 0x80000000) {
+	if (sp & 3 || (uintptr_t)sp < 0x80000000u) {
 		(*printfn) ("SP 0x%x: not in kernel\n", sp);
 		ra = 0;
 		subr = 0;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201002271944.o1RJii6F055467>