Date: Fri, 14 Nov 2003 19:01:29 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: rizzo@icir.org Cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/an if_an.c if_anreg.h src/sys/dev/bfe if_bfe.c src/sys/dev/my if_my.c src/sys/dev/owi if_owi.c if_wivar.h src/sys/dev/re if_re.c src/sys/dev/wl if_wl.c src/sys/pci if_dc.c if_dcreg.h if_pcn.c if_pcnreg.h if_rl.c ... Message-ID: <20031114.190129.61829458.imp@bsdimp.com> In-Reply-To: <20031114132714.A88606@xorpc.icir.org> References: <200311141900.hAEJ0XBn058450@repoman.freebsd.org> <20031114132714.A88606@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20031114132714.A88606@xorpc.icir.org>
Luigi Rizzo <rizzo@icir.org> writes:
: On Fri, Nov 14, 2003 at 11:00:33AM -0800, Sam Leffler wrote:
: > sam 2003/11/14 11:00:33 PST
: ...
: > Log:
: > Drop the driver lock around calls to if_input to avoid a LOR when
: > the packets are immediately returned for sending (e.g. when bridging
: > or packet forwarding). There are more efficient ways to do this
: > but for now use the least intrusive approach.
:
: the number of places that this commit had to touch makes me
: wonder whether it wouldn't be better to include somehow
: these calls into the if_input routine somehow...
That would be hard w/o passing the lock into the if_input routine, or
putting the lock in ifnet.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031114.190129.61829458.imp>