Date: Mon, 8 Feb 2021 23:29:25 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Alexander Richardson <arichardson@freebsd.org>, Mateusz Guzik <mjg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 81e074d57dfc - main - libkern: use compiler builtins for strcpy, strcmp and strlen Message-ID: <B81CA390-D30C-48B2-8B80-2D07E5A71117@freebsd.org> In-Reply-To: <CA%2BZ_v8q6DhnDNqc-Y%2BNap8HdErRaxgbqV4wVsRiZL%2B%2BrdMYMqg@mail.gmail.com> References: <202102081915.118JFVS0067851@gitrepo.freebsd.org> <8F5A406F-FB06-4D52-8CD7-1DCE01B6C126@freebsd.org> <CA%2BZ_v8q6DhnDNqc-Y%2BNap8HdErRaxgbqV4wVsRiZL%2B%2BrdMYMqg@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On 8 Feb 2021, at 22:08, Alexander Richardson <arichardson@freebsd.org> wrote: > > On Mon, 8 Feb 2021, 19:37 Jessica Clarke, <jrtc27@freebsd.org> wrote: >> On 8 Feb 2021, at 19:15, Mateusz Guzik <mjg@FreeBSD.org> wrote: >> > >> > The branch main has been updated by mjg: >> > >> > URL: https://cgit.FreeBSD.org/src/commit/?id=81e074d57dfcd86f152e2848dc44b77087ee7a2d >> > >> > commit 81e074d57dfcd86f152e2848dc44b77087ee7a2d >> > Author: Mateusz Guzik <mjg@FreeBSD.org> >> > AuthorDate: 2021-02-07 19:50:25 +0000 >> > Commit: Mateusz Guzik <mjg@FreeBSD.org> >> > CommitDate: 2021-02-08 19:15:21 +0000 >> > >> > libkern: use compiler builtins for strcpy, strcmp and strlen >> >> Why? > > > I guess because the kernel uses -ffreestanding, so the libcall inlining optimization requires explicit uses of __builtin_foo That would make sense, but such info belongs in the commit message, a comment or both... As it stands the message is not useful as anyone can see from reading the diff that that's what it does. Jesshome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B81CA390-D30C-48B2-8B80-2D07E5A71117>