Date: Tue, 26 Apr 2016 09:15:20 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Pedro Giffuni <pfg@freebsd.org> Cc: "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: HEADS UP: I will revert this. (was Re: svn commit: r298443 - head/usr.bin/stat) Message-ID: <CAOfEmZj=%2BqzktGMarcWSdHVm4wmtNiD58x1EBoeUunbhnUttQg@mail.gmail.com> In-Reply-To: <69810c2f-ee32-5d7b-8367-689b2afb0d97@FreeBSD.org> References: <201604220343.u3M3h69m058753@repo.freebsd.org> <CAGVycparsgVzxGXPy2R=YG_noHxDbVKkvkPu3KvEh8RpMH56Sg@mail.gmail.com> <69810c2f-ee32-5d7b-8367-689b2afb0d97@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2016-04-26 5:33 GMT+08:00 Pedro Giffuni <pfg@freebsd.org>: > Hi Marcelo; > > Hi; > > I assume you have been very busy. > > I will revert this in a couple of hours unless you either explain > or revert it yourself. > Fixed! Sorry my delay, I got a bit busy! Thanks for the hands up. > > Pedro. > > On 04/23/16 04:23, luke wrote: > >> On Fri, Apr 22, 2016 at 11:43 AM, Marcelo Araujo <araujo@freebsd.org >> <mailto:araujo@freebsd.org>> wrote: >> >> Author: araujo >> Date: Fri Apr 22 03:43:06 2016 >> New Revision: 298443 >> URL: https://svnweb.freebsd.org/changeset/base/298443 >> >> Log: >> Use macro MAX() from sys/param.h. >> >> MFC after: 2 weeks. >> >> Modified: >> head/usr.bin/stat/stat.c >> >> Modified: head/usr.bin/stat/stat.c >> >> ============================================================================== >> --- head/usr.bin/stat/stat.c Fri Apr 22 03:37:27 2016 >> (r298442) >> +++ head/usr.bin/stat/stat.c Fri Apr 22 03:43:06 2016 >> (r298443) >> @@ -1025,7 +1025,7 @@ format1(const struct stat *st, >> * >> * Nanoseconds: long. >> */ >> - (void)snprintf(tmp, sizeof(tmp), "%dld", prec > 9 ? >> 9 : prec); >> + (void)snprintf(tmp, sizeof(tmp), "%dld", MAX(9, >> prec)); >> (void)strcat(lfmt, tmp); >> >> /* >> _______________________________________________ >> svn-src-head@freebsd.org <mailto:svn-src-head@freebsd.org> mailing >> list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to >> "svn-src-head-unsubscribe@freebsd.org >> <mailto:svn-src-head-unsubscribe@freebsd.org>" >> >> >> >> Hi, >> >> Should this be MIN() ? >> >> (void)snprintf(tmp, sizeof(tmp), "%dld", MIN(prec, 9)); >> >> >> -- >> Chang-Hsien Tsai >> >> -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZj=%2BqzktGMarcWSdHVm4wmtNiD58x1EBoeUunbhnUttQg>