Date: Tue, 07 Oct 2025 11:00:10 +0200 From: Olivier Certner <olce@freebsd.org> To: Mateusz Guzik <mjguzik@gmail.com>, Mateusz Guzik <mjg@freebsd.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 84f981ba57e7 - main - nullfs: shrink null_node to 32 bytes Message-ID: <2940490.iL6vRArjjl@ravel> In-Reply-To: <CAGudoHEf%2BVzj_ZTv8otuz_FCh3CfO_tok=%2BbGS=__u5qnBkuJA@mail.gmail.com> References: <202510061823.596IN7oZ084715@gitrepo.freebsd.org> <CAGudoHEWXDwcsXcz=NtHBWFiO48DvRBNCEQFLHXJs52TpbnJWA@mail.gmail.com> <CAGudoHEf%2BVzj_ZTv8otuz_FCh3CfO_tok=%2BbGS=__u5qnBkuJA@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > > For the hash to be at all useful the chains are supposed to be short. > > > > Or to put it differently, a sensibly sized hash with a sensible > > hashing function makes it automatically fine. > > > > This was worthwhile to do because the original size of 40 bytes is a > > very poor fit for the allocator. > > > > fwiw the namecache already works this way for few years. > > > > the regular vnode hash should probably get the same treatment, saving > > 8 bytes off of struct vnode > > I can concede it would make sense to include this in the commit message. That's a reasonable trade-off, but it's important that such choices are explained in the commit message and/or code comments. Next time, please consider putting up Phabricator reviews even for such "small" changes, where we would have had the opportunity to mention this before commit. Thanks and regards. -- Olivier Certner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmjk1psACgkQjKEwQJce JicviBAAs01XxVdfCbvErgsCm3v8n9zlp8IJYKL7KKzI1+9eQFRmCR/C735QIcOp 9VSgl35MVL4pm074O79HNn6iNXJCXcqCRFxDKrLWH6afReGQ4CkwhOOFWNBeCrty 037s0d3GaBzOzqxRzbSfEDf9+Yvsc2vKoJGCWmtu4eZ/smz6nGK7AiHCNaW8ldRv zuy0yFhP+gw4OkAm0W6N8a1gLq7/2HT6PdZ3bxGD+ZYXI8mGZ877C44tTqLsAkPZ O89Yw8dGdBCnR2lhr/fcyRYicJa+j92t48CK+h9wdW213evzt+yU/aS/4+HkBznC Tkdw/TlK3k8x6/ECPER09v6XKOVw67z6HxMOf51G+X4Jo3lj+a1LOhcUWNZvSDJw pOmpWBI5UDqNwstUv+BKlND0wbBUCGp5lq/CQcY8XFFn0TWILBR0EeJsXTgLqgPk j1QI4591xT86IUO+L9xyMJ/o9OUhL4L9s1KMNAMBFi0rTPoV72nwJu4QY1Klnc4h jaNc6JKKKPPSPvVIcOFNRs/SDKpCcR8ln0dJ9+PsufIIMcMz9QlX3+zXgheH9ixQ JnFTgM71P1bDKlTXBe1N4nYNl7S2BltwNxwiF/gVG+jFVgTi5iSuhF5YgA8lfg2C cVN7Uz+ccJ6AWCBveqLQJThHGKQeGnp+GUrRhZBh9T4ni/wHX6s= =BPAy -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2940490.iL6vRArjjl>