Date: Wed, 31 Dec 2025 15:02:44 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Rene Ladan <rene@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject: Re: git: a3a0b0e15375 - main - net-mgmt/{victoria-metrics,vmutils}: update to version 1.132.0
Message-ID: <aVU7FPxNk_taOaHs@FreeBSD.org>
In-Reply-To: <aVU2FGqO-58mufGG@freefall.freebsd.org>
References: <695106b6.2147a.2d8c6be2@gitrepo.freebsd.org> <aVUCGju4in9DL1gk@freefall.freebsd.org> <aVUy0QlsEwMx2DHW@FreeBSD.org> <aVU2FGqO-58mufGG@freefall.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Wed, Dec 31, 2025 at 02:41:24PM +0000, Rene Ladan wrote:
> On Wed, Dec 31, 2025 at 02:27:29PM +0000, Alexey Dokuchaev wrote:
> > On Wed, Dec 31, 2025 at 10:59:38AM +0000, Rene Ladan wrote:
> > > On Sun, Dec 28, 2025 at 10:30:14AM +0000, Alexey Dokuchaev wrote:
> > > > commit a3a0b0e15375ebf059840f06c4181bc9c1742a5b
> > > >
> > > > net-mgmt/{victoria-metrics,vmutils}: update to version 1.132.0
> > > >
> > > [...]
> > >
> > > > PR: 284564
> > > > Submitted by: Jan van der Lugt
> > > > Reported by: Michael Gruner
> > >
> > > Can you attribute these people appropriately by setting the commit author
> > > instead of using the long-deprecated "Submitted by" tag?
> >
> > It is correctly attributed: the patch it mine and incorporates two
> > *suggestions* made by those people, it's not if I applied submitted patch
> > verbatim.
>
> Then just say so.
I try to be accurate with attribution, and I think I did. Jan van der Lugt
_submitted_ PR (hence the tag), described the problem and provided a quick'n'
dirty, non-committable patch which I glanced over and threw away. Michael
wrote me an email and _reported_ his problem which was about the wrong port
number in the script. Then I've *myself* created the final patch and wrote
an elaborate commit log based on those gentlemen's input. So, to summarize:
PR (number)
Submitted by: (person who submitted that PR for problem #1)
Reported by: (another person who reported problem #2)
> > "improper" commit logs bother you, perhaps you should start with your own
> > ones, e.g. for commit 655a76dc986d?
>
> Uhm, that is just a commit from Tools/scripts/rmport, with some half-baked
> fixups?
Commit log is bogus, only the subject line makes sense. The last (closing)
line is a port name alone, which makes no sense to me: why is it there? what
is it supposed to tell the reader? :-/
./danfe
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aVU7FPxNk_taOaHs>