Date: Mon, 11 Mar 2024 12:40:38 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: Max Brazhnikov <makc@freebsd.org> Cc: Neel Chauhan <nc@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ca21dddc0e31 - main - graphics/libnsgif: Update to 1.0.0 Message-ID: <CAFDf7UK3PiOZJ2xAYkAMDuvQ0XY=FBfWbE13ydvT1_KkyV0z3Q@mail.gmail.com> In-Reply-To: <2911916.SSXfckUlLJ@mercury> References: <202402161824.41GIOgvd075302@gitrepo.freebsd.org> <CAFDf7UKu=kTdmSM%2Bd08oRxd05eRnndwKQWGLBGBibRPrjWrHrA@mail.gmail.com> <2911916.SSXfckUlLJ@mercury>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello Max, What about create a repo copy of libnsgit 0.2.1 and renamed it to libnsgit02 or libnsgit021. For what I know only graphics/imv fails to build with 1.0.0: NSGIF_BROKEN=3D fails to build with libnsgif 1.0.0, see also https://lists.sr.ht/~exec64/imv-devel/%3CCAFDf7UKQCAO5VXqykRCnpHG6u0owdXRnk= 5kt0S3b-aTkpuF66Q%40mail.gmail.com%3E NSGIF_LIB_DEPENDS=3D libnsgif.so:graphics/libnsgif NSGIF_MESON_ENABLED=3D libnsgif So I don't know if it is worthed to make this port. Also I didn't get any complains about imv broken option. Cheers, Max Brazhnikov <makc@freebsd.org> escreveu (domingo, 18/02/2024 =C3=A0(s) 1= 2:01): > > Hi all, > > On Sat, 17 Feb 2024 07:26:22 +0000 Nuno Teixeira wrote: > > Did you do a consumers test? > > > > -include/libnsgif.h > > +include/nsgif.h > > > > graphics/imv: > > ../src/backend_libnsgif.c:9:10: fatal error: 'libnsgif.h' file not foun= d > > 9 | #include <libnsgif.h> > > > > Any clues on recomended way to fix? > > > > Neel Chauhan <nc@freebsd.org> escreveu (sexta, 16/02/2024 =C3=A0(s) 18:= 24): > > > > > > The branch main has been updated by nc: > > > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dca21dddc0e31a6be1db1= f5966a283f52d89cddf5 > > > > > > commit ca21dddc0e31a6be1db1f5966a283f52d89cddf5 > > > Author: Neel Chauhan <nc@FreeBSD.org> > > > AuthorDate: 2024-02-16 17:42:44 +0000 > > > Commit: Neel Chauhan <nc@FreeBSD.org> > > > CommitDate: 2024-02-16 18:24:27 +0000 > > > > > > graphics/libnsgif: Update to 1.0.0 > > > --- > > > graphics/libnsgif/Makefile | 2 +- > > > graphics/libnsgif/distinfo | 6 +++--- > > > graphics/libnsgif/files/patch-Makefile | 10 ---------- > > > graphics/libnsgif/pkg-plist | 4 ++-- > > > 4 files changed, 6 insertions(+), 16 deletions(-) > > > > > > diff --git a/graphics/libnsgif/Makefile b/graphics/libnsgif/Makefile > > > index 09c07dda9f9a..7e0697f3b78c 100644 > > > --- a/graphics/libnsgif/Makefile > > > +++ b/graphics/libnsgif/Makefile > > > @@ -1,5 +1,5 @@ > > > PORTNAME=3D libnsgif > > > -PORTVERSION=3D 0.2.1 > > > +PORTVERSION=3D 1.0.0 > > > CATEGORIES=3D graphics > > > MASTER_SITES=3D http://download.netsurf-browser.org/libs/releases/ > > > EXTRACT_SUFX=3D -src.tar.gz > > skip > > > > diff --git a/graphics/libnsgif/pkg-plist b/graphics/libnsgif/pkg-plis= t > > > index 38365be87a3a..927929719b65 100644 > > > --- a/graphics/libnsgif/pkg-plist > > > +++ b/graphics/libnsgif/pkg-plist > > > @@ -1,5 +1,5 @@ > > > -include/libnsgif.h > > > +include/nsgif.h > > > lib/libnsgif.so > > > -lib/libnsgif.so.0 > > > +lib/libnsgif.so.1 > > > lib/libnsgif.so.%%VERSION%% > > > libdata/pkgconfig/libnsgif.pc > > What was the reason for this commit? > > Changes like this require from the maintainer to test consumer ports. Req= uest exp-run if you can't test all consumers locally, notify other maintain= ers about the change (exp-run won't catch all cases), ask for help if you n= eed it. To me committing untested stuff that breaks other ports is disrespe= ctful to fellow maintainers and users. > > Cheers, > Max > > > --=20 Nuno Teixeira FreeBSD Committer (ports)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UK3PiOZJ2xAYkAMDuvQ0XY=FBfWbE13ydvT1_KkyV0z3Q>