Date: Wed, 3 Oct 2018 15:28:45 +0200 From: Jakob Alvermark <jakob@alvermark.net> To: David Wolfskill <david@catwhisker.org>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: Sound issues with Dell Latitude 7490 (kabylake) Message-ID: <a8f4cc37-8639-ab64-b3cb-4239127f9e43@alvermark.net> In-Reply-To: <20181003130645.GH1118@albert.catwhisker.org> References: <CAECmPws%2BqW0-zy0ucN0JSDEX=JLpAHm=AbXJYRJ-Mejnoy4ecA@mail.gmail.com> <85518f55-20a8-f534-7266-a9e847912afc@alvermark.net> <CAECmPwvqaWbWDu7TVpYxxTr7-Zr=RWnUWi1C=8S=TOmrBKdpZg@mail.gmail.com> <596a89fa-d7a3-1d39-d296-e07359cb487f@alvermark.net> <20181003130645.GH1118@albert.catwhisker.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/3/18 3:06 PM, David Wolfskill wrote: > On Mon, Oct 01, 2018 at 11:12:25PM +0200, Jakob Alvermark wrote: >> .... >> Do the headphones work with this patch? >> >> Index: sys/dev/sound/pci/hda/hdaa.c >> =================================================================== >> --- sys/dev/sound/pci/hda/hdaa.c (revision 339076) >> +++ sys/dev/sound/pci/hda/hdaa.c (working copy) >> @@ -5034,11 +5034,13 @@ >> pincap = w->wclass.pin.cap; >> >> /* Disable everything. */ >> + /* >> w->wclass.pin.ctrl &= ~( >> HDA_CMD_SET_PIN_WIDGET_CTRL_HPHN_ENABLE | >> HDA_CMD_SET_PIN_WIDGET_CTRL_OUT_ENABLE | >> HDA_CMD_SET_PIN_WIDGET_CTRL_IN_ENABLE | >> HDA_CMD_SET_PIN_WIDGET_CTRL_VREF_ENABLE_MASK); >> + */ >> >> if (w->enable == 0) { >> /* Pin is unused so left it disabled. */ >> .... > Thank you! This addressed the long-standing (Reported: 2015-05-29 > 21:15 UTC) issue I have had with my laptop (Dell Precision M4800), as > documented in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200526 > -- now updated to reflect the fix. That's great! Glad to hear it helped. This is probably not a proper fix, but it helps to understand the problem. Could you post the output of 'sysctl dev.hdaa' with and without the patch so we can see what's different? Jakob
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a8f4cc37-8639-ab64-b3cb-4239127f9e43>