Date: Mon, 15 Sep 2014 16:31:13 +0000 From: David Somayajulu <david.somayajulu@qlogic.com> To: "Andrey V. Elsukov" <ae@FreeBSD.org>, David C Somayajulu <davidcs@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: RE: svn commit: r265703 - in head: share/man/man4 sys/dev/bce sys/dev/bxe sys/modules/bce Message-ID: <49F5640B08EAA94DAF2F6B6145E6A08A012866587B@AVMB1.qlogic.org> In-Reply-To: <54167255.5090806@FreeBSD.org> References: <201405081940.s48Jebh5041824@svn.freebsd.org> <54167255.5090806@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Andrey, When I didn't have the clean override, "make clean" was not cleaning prope= rly when I built a standalone loadable driver. Perhaps we can change "clean= " in bxe/Makefile and bce/Makefile to "dclean". Thanks David S. -----Original Message----- From: Andrey V. Elsukov [mailto:ae@FreeBSD.org] Sent: Sunday, September 14, 2014 10:00 PM To: David C Somayajulu; src-committers@freebsd.org; svn-src-all@freebsd.org= ; svn-src-head@freebsd.org Subject: Re: svn commit: r265703 - in head: share/man/man4 sys/dev/bce sys/= dev/bxe sys/modules/bce On 08.05.2014 23:40, David C Somayajulu wrote: > Author: davidcs > Date: Thu May 8 19:40:37 2014 > New Revision: 265703 > URL: http://svnweb.freebsd.org/changeset/base/265703 > Modified: head/sys/modules/bce/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/modules/bce/Makefile Thu May 8 19:35:29 2014 (r2= 65702) > +++ head/sys/modules/bce/Makefile Thu May 8 19:40:37 2014 (r2= 65703) > @@ -5,4 +5,9 @@ SRCS=3D opt_bce.h if_bce.c miibus_if.h mii > > #CFLAGS +=3D -DBCE_DEBUG=3D0 > > +clean: > + rm -f opt_bdg.h device_if.h bus_if.h pci_if.h export_syms > + rm -f *.o *.kld *.ko > + rm -f @ machine x86 miibus_if.h miidevs.h opt_bce.h > + > .include <bsd.kmod.mk> Hi, why did you override 'clean' target? It works well by default, but now some files don't deleted, e.g. when you b= uild modules with DEBUG_FLAGS. Also the same problem with if_bxe(4) module. -- WBR, Andrey V. Elsukov ________________________________ This message and any attached documents contain information from QLogic Cor= poration or its wholly-owned subsidiaries that may be confidential. If you = are not the intended recipient, you may not read, copy, distribute, or use = this information. If you have received this transmission in error, please n= otify the sender immediately by reply e-mail and then delete this message.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49F5640B08EAA94DAF2F6B6145E6A08A012866587B>