Date: Wed, 25 Jul 2007 00:42:59 -0500 From: Stephen Montgomery-Smith <stephen@math.missouri.edu> To: Paul Schmehl <pauls@utdallas.edu>, FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: How do you remove unneeded patch files? Message-ID: <46A6E2E3.7020305@math.missouri.edu> In-Reply-To: <20070724195845.GA37472@droso.net> References: <CBBCC6FE2F582A58EE7F95CD@utd59514.utdallas.edu> <20070724195845.GA37472@droso.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Erwin Lansing wrote: > On Tue, Jul 24, 2007 at 02:41:04PM -0500, Paul Schmehl wrote: >> I'm working on a port upgrade. The existing port has a number of patch >> files in FILESDIR that are no longer needed. (The changes they made have >> been incorporated into the distro.) What's the appropriate way to submit >> those changes? Normally, a send-pr submission will contain the patches for >> existing port files. There is no patch for these. They need to be removed. >> >> I could do this: diff -Naur files/original_patch_file files/empty_file, but >> I don't know if that removes the file or simply replaces it with an empty >> one. >> > The result of using that patch would be an empty file. This is also > alright to submit it that way, but as a courtesy to the committer (and > also to make sure he doesn't forget) it would be good to mention in the > PR that file/xyz and files/abc should be removed completely. You really should be unambiguous and clear in explaining that the files are to be deleted. I have had a couple of experiences where ports I maintain did not have the files deleted, and I had to remind the committer. Stephen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46A6E2E3.7020305>