Date: Tue, 20 Aug 2019 01:06:43 +0000 (UTC) From: "Stephen J. Kiernan" <stevek@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r351244 - head/sys/dev/usb/net Message-ID: <201908200106.x7K16hWT067244@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: stevek Date: Tue Aug 20 01:06:43 2019 New Revision: 351244 URL: https://svnweb.freebsd.org/changeset/base/351244 Log: usb_ethernet.h includes a number of mii headers, but only does so in order to have struct mii_data available. However, it only really needs a forward declaration of struct mii_data for use in pointer form for the return type of a function prototype. Custom kernel configuration that have usb and fdt enabled, but no miibus, end up with compilation failures because miibus_if.h will not get generated. Due to the above, the following changes have been made to usb_ethernet.h: * remove the inclusion of mii headers * forward-declare struct mii_data * include net/ifq.h to satify the need for complete struct ifqueue Reviewed by: ian Obtained from: Juniper Networks, Inc. Differential Revision: https://reviews.freebsd.org/D21293 Modified: head/sys/dev/usb/net/usb_ethernet.h Modified: head/sys/dev/usb/net/usb_ethernet.h ============================================================================== --- head/sys/dev/usb/net/usb_ethernet.h Tue Aug 20 00:50:17 2019 (r351243) +++ head/sys/dev/usb/net/usb_ethernet.h Tue Aug 20 01:06:43 2019 (r351244) @@ -45,14 +45,11 @@ #include <net/if_dl.h> #include <net/if_media.h> #include <net/if_types.h> +#include <net/ifq.h> #include <net/bpf.h> #include <net/ethernet.h> -#include "miibus_if.h" - -#include <dev/mii/mii.h> -#include <dev/mii/miivar.h> - +struct mii_data; struct usb_ether; struct usb_device_request;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201908200106.x7K16hWT067244>