Date: Thu, 21 Oct 2010 06:52:14 +0000 (UTC) From: Edwin Groothuis <edwin@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/usr.sbin/lpr/lpr lpr.c Message-ID: <201010210652.o9L6qOFq014060@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
edwin 2010-10-21 06:52:14 UTC
FreeBSD src repository
Modified files:
usr.sbin/lpr/lpr lpr.c
Log:
SVN rev 214124 on 2010-10-21 06:52:14Z by edwin
Fix printing of files located on ZFS filesystem with an st_dev or
st_ino larger than 2**31.
From the PR:
Printing from a ZFS filesystem using 'lp' fails and returns an
email reporting "Your printer job was not printed because it was
not linked to the original file".
In order to protect against files being switched when files
are printed using 'lp' or 'lpr -s', the st_dev and st_ino
values for the original file are saved by lpr and verified
by lpd before the file is printed. Unfortunately, lpr prints
both values using '%d' (although both fields are unsigned)
and lpd(8) assumes a string of decimal digits.
ZFS (at least) generates st_dev values greater than 2^31-1,
resulting in negative values being printed - which lpd cannot
parse, leading it to report that the file has been switched.
A similar problem would occur with large inode numbers.
How-To-Repeat:
Find a file with either st_dev or st_ino greater than 2^31-1
(stat(1) will report both numbers) and print it with 'lpq -s'.
This should generate an email reporting that the file could
not be printed because it was not linked to the original file
PR: bin/151567
Submitted by: Peter Jeremy <Peter.Jeremy@alcatel-lucent.com>
MFC after: 1 week
Revision Changes Path
1.45 +1 -1 src/usr.sbin/lpr/lpr/lpr.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010210652.o9L6qOFq014060>