Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 07 Nov 2002 16:33:51 -0500 (EST)
From:      "David A. Panariti" <davep.freebsd@meduseld.net>
To:        freebsd-ports@FreeBSD.ORG
Subject:   bsd.port.mk, PORTCOMMENT and devel/bison
Message-ID:  <20021107.163351.846981250.davep@meduseld.net>

next in thread | raw e-mail | index | archive | help
While installing the port for devel/bison, I kept getting errors.
It turns out that bison has a PORTCOMMENT value with parens in it
which confuses the shell.
Putting quotes around the ${PORTCOMMENT} being echoed into the
+COMMENT file fixed things.
There may be other cases where vars should be quoted, too.  Sorry, but
I don't have the time to search for them.
I'm not subscribed to this list, so I appreciate being CC'd on any
followup.

davep

here is the patch:

--- bsd.port.mk.ORIG	Thu Nov  7 16:18:39 2002
+++ bsd.port.mk	Thu Nov  7 16:18:48 2002
@@ -3566,7 +3566,7 @@
 		if [ -f ${COMMENT} ]; then \
 			${CP} ${COMMENT} ${PKG_DBDIR}/${PKGNAME}/+COMMENT; \
 		else \
-			${ECHO_CMD} ${PORTCOMMENT} > ${PKG_DBDIR}/${PKGNAME}/+COMMENT; \
+			${ECHO_CMD} "${PORTCOMMENT}" > ${PKG_DBDIR}/${PKGNAME}/+COMMENT; \
 		fi; \
 		if [ -f ${PKGINSTALL} ]; then \
 			${CP} ${PKGINSTALL} ${PKG_DBDIR}/${PKGNAME}/+INSTALL; \

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021107.163351.846981250.davep>