Date: Thu, 19 Apr 2007 08:02:51 +0000 (UTC) From: Joseph Koshy <jkoshy@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern subr_witness.c src/sys/dev/hwpmc hwpmc_logging.c hwpmc_mod.c hwpmc_piv.c Message-ID: <200704190802.l3J82pW2027640@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jkoshy 2007-04-19 08:02:51 UTC
FreeBSD src repository
Modified files:
sys/kern subr_witness.c
sys/dev/hwpmc hwpmc_logging.c hwpmc_mod.c hwpmc_piv.c
Log:
Fix witness(4) warnings about mutex use.
Group mutexes used in hwpmc(4) into 3 "types" in the sense of
witness(4):
- leaf spin mutexes---only one of these should be held at a time,
so these mutexes are specified as belonging to a single witness
type "pmc-leaf".
- `struct pmc_owner' descriptors are protected by a spin mutex of
witness type "pmc-owner-proc". Since we call wakeup_one() while
holding these mutexes, the witness type of these mutexes needs
to dominate that of "sleepq chain" mutexes.
- logger threads use a sleep mutex, of type "pmc-sleep".
Submitted by: wkoszek (earlier patch)
Revision Changes Path
1.7 +3 -2 src/sys/dev/hwpmc/hwpmc_logging.c
1.28 +26 -17 src/sys/dev/hwpmc/hwpmc_mod.c
1.14 +1 -1 src/sys/dev/hwpmc/hwpmc_piv.c
1.230 +10 -0 src/sys/kern/subr_witness.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704190802.l3J82pW2027640>