Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Feb 2012 04:21:37 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Ryan Steinmetz <zi@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/net/freeradius/files patch-doc__examples__mysql.sql
Message-ID:  <20120220042137.GA68349@FreeBSD.org>
In-Reply-To: <201202191401.q1JE11pT092029@repoman.freebsd.org>
References:  <201202191401.q1JE11pT092029@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 19, 2012 at 02:01:01PM +0000, Ryan Steinmetz wrote:
> zi          2012-02-19 14:01:01 UTC
> 
>   Added files:
>     net/freeradius/files patch-doc__examples__mysql.sql
>   Log:
>   - Remove warning when importing MySQL example script
>   - Do not bump PORTREVISION

These types of simple largely mechanical fixes perhaps are better done with
REINPLACE_CMD.  It's short, readable, does not require an extra file to keep
track of and waste an inode.

Just an observation though; technically, nothing is wrong with the patch.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120220042137.GA68349>