Date: Mon, 9 Jan 2012 07:38:39 -0800 From: Devin Teske <devin.teske@fisglobal.com> To: Dimitry Andric <dim@FreeBSD.org> Cc: "<svn-src-head@freebsd.org>" <svn-src-head@freebsd.org>, "<svn-src-all@freebsd.org>" <svn-src-all@freebsd.org>, Sergey Kandaurov <pluknet@freebsd.org>, "<src-committers@freebsd.org>" <src-committers@freebsd.org> Subject: * Re: svn commit: r228985 - head/sys/boot/forth Message-ID: <DAC05E8F-C667-4580-BCF2-719627628FAD@fisglobal.com> In-Reply-To: <4F0AE274.8010907@FreeBSD.org> References: <201112300624.pBU6OxO9098906@svn.freebsd.org> <4F08A518.8090207@FreeBSD.org> <CAE-mSOJS5a%2BxCTFmtUL3R%2B3VZJupgDo7eFbAc70wmtWRW6s-3Q@mail.gmail.com> <4F0AE274.8010907@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 9, 2012, at 4:49 AM, Dimitry Andric <dim@FreeBSD.org> wrote: > On 2012-01-08 21:35, Sergey Kandaurov wrote: > ... >> So, the problem arise when beastie_disable is set. >>=20 >> In this case menu.rc is not evaluated and consequently menu-unset does >> not have a body yet. This results in the ficl warning "not found" when >> try-menu-unset calls menu-unset. The warning cannot be handled with catch >> as seen with the code in head. >> Otherwise, when beastie is enabled, all works as it should. >>=20 >> To "fix" the problem I replaced 'catch' with 'sfind', so that we can >> conditionally call menu-unset only when the definition is present. >>=20 >> Please try the following patch. I tested it with enabled/disabled beastie >> and loader_color over serial console. I would also like to get a review >> from Devin Teske to see if this change is acceptable. >=20 > Yes, this patch makes the warning disappear. Thanks! Please also see additional notes in PR kern/163938 (additional patching to = same file for same problem). --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DAC05E8F-C667-4580-BCF2-719627628FAD>