Date: Mon, 10 Apr 2023 07:47:28 +0800 From: Po-Chuan Hsieh <sunpoet@sunpoet.net> To: Dima Panov <fluffy@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Guido Falsi <madpilot@freebsd.org>, Daniel Engberg <diizzy@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 72ad532057c9 - main - archivers/zstd: Add CMake config files and adjust Makefile Message-ID: <CAMHz58SPsX5ZffMa8hkvgV36%2B-T1Dq%2BV80Yd5yymMz=sPRvnUQ@mail.gmail.com> In-Reply-To: <b468b6e6-cbbe-86cf-9eed-8c945717c798@FreeBSD.org> References: <202304050615.3356FKNq062154@gitrepo.freebsd.org> <7accd096-7871-29ad-0824-c035504d01b0@FreeBSD.org> <ZC7GUhyVa%2Bjbpe1S@FreeBSD.org> <e77963c0-fdd0-5fc5-049d-aa7853ef5c51@FreeBSD.org> <ZC7KBj7lKm8VRtmn@FreeBSD.org> <b468b6e6-cbbe-86cf-9eed-8c945717c798@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000c32ac905f8efe3fd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Fri, Apr 7, 2023 at 5:36=E2=80=AFAM Dima Panov <fluffy@freebsd.org> wrot= e: > Moin-moin! > > On 06.04.2023 16:32, Alexey Dokuchaev wrote: > > On Thu, Apr 06, 2023 at 03:19:55PM +0200, Guido Falsi wrote: > >> On 06/04/23 15:17, Alexey Dokuchaev wrote: > >>> On Wed, Apr 05, 2023 at 02:20:21PM +0200, Guido Falsi wrote: > >>>> On 05/04/23 08:15, Daniel Engberg wrote: > >>>>> commit 72ad532057c9f9fb6fa370c80f663c005e9dd021 > >>>>> > >>>>> archivers/zstd: Add CMake config files and adjust Makefile > >>>>> > >>>>> - Use upstream's short test for "make test" > >>>>> - Use verbose output by default during build > >>>>> * Tweak Makefile to follow Porters Handbook more closely > >>>>> * Install CMake files (taken from CMake build framework) > >>>>> > >>>>> PR: 267652 > >>>>> Reported by: fluffy > >>>>> Approved by: portmgr (maintainer timeout, 1+ month) > >>>> > >>>> Looks like this, un[luckily], causes a failure with devel/qt6-base > >>>> (abridged error, full log if needed): > >>>> > >>>> ld: error: relocation R_X86_64_32 cannot be used against local symbo= l; > >>>> recompile with -fPIC > >>>> >>> defined in /usr/local/lib/libzstd.a(zstd_common.o) > >>>> >>> referenced by zstd_common.c > >>>> >>> zstd_common.o:(ZSTD_versionString) in archive > >>> > >>> Yeah, I'm seeing this as well. Admittedly, the whole commit looks > >>> dubious to me, with all these out-of-blue new files and gratuitous > >>> changes. I guess sunpoet@ should revert it and merge only needed > >>> parts thereof properly. > > Nope. > This commit unmasked the real problem of using autocrap tools to build > zstd -- a broken static library. > Issue was not raised before 'cause cmake configs was absent and qt6 > (and may be other consumers) hooks up only shared lib. > It should be fixed in ports 454e3c91ae9105a9af1939c9632424083ed3bbdb. I've tested unmodified devel/qt6-base and it builds fine. > Just to be clear -- I have a version of port converted to pure cmake buil= d > and > it produce a valid static library which correctly liked by any consumer. > > Anyway, number of consumers which require cmake'd zstd will grow in near > future. > openimageio/opencolorio/opnehadinglanguage are already require it to push > new versions to the ports tree. > Please let me know if more ports are broken. > > >> > >> I have only reported the issue as an early warning, as I said. > >> > >> Regarding qt6-base a fix has already been proposed here by diizzy: > >> > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270664 > > > > Ah, good to know it's being taken care of, thanks for sharing! > > Nope. This patch not fixes anything but masking the real issue with broke= n > libzstd.a by prefer dynamic library over static to link. > > > > -- > Sincerely, > Dima (fluffy@FreeBSD.org, https://t.me/FluffyBSD) > (desktop, kde, x11, office, ports-secteam)@FreeBSD team > --000000000000c32ac905f8efe3fd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hi,</div><br><div class=3D"gmail_quote"><div dir=3D"l= tr" class=3D"gmail_attr">On Fri, Apr 7, 2023 at 5:36=E2=80=AFAM Dima Panov = <<a href=3D"mailto:fluffy@freebsd.org">fluffy@freebsd.org</a>> wrote:= <br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8= ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Moin-moin!<br> <br> On 06.04.2023 16:32, Alexey Dokuchaev wrote:<br> > On Thu, Apr 06, 2023 at 03:19:55PM +0200, Guido Falsi wrote:<br> >> On 06/04/23 15:17, Alexey Dokuchaev wrote:<br> >>> On Wed, Apr 05, 2023 at 02:20:21PM +0200, Guido Falsi wrote:<b= r> >>>> On 05/04/23 08:15, Daniel Engberg wrote:<br> >>>>> commit 72ad532057c9f9fb6fa370c80f663c005e9dd021<br> >>>>><br> >>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 archivers/zstd: Add CMake c= onfig files and adjust Makefile<br> >>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 <br> >>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 - Use upstream's short = test for "make test"<br> >>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 - Use verbose output by def= ault during build<br> >>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 * Tweak Makefile to follow = Porters Handbook more closely<br> >>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 * Install CMake files (take= n from CMake build framework)<br> >>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 <br> >>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0267652<br> >>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 f= luffy<br> >>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 p= ortmgr (maintainer timeout, 1+ month)<br> >>>><br> >>>> Looks like this, un[luckily], causes a failure with devel/= qt6-base<br> >>>> (abridged error, full log if needed):<br> >>>><br> >>>> ld: error: relocation R_X86_64_32 cannot be used against l= ocal symbol;<br> >>>> recompile with -fPIC<br> >>>>=C2=A0 =C2=A0 >>> defined in /usr/local/lib/libzst= d.a(zstd_common.o)<br> >>>>=C2=A0 =C2=A0 >>> referenced by zstd_common.c<br> >>>>=C2=A0 =C2=A0 >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0zstd_common.o:(ZSTD_versionString) in archive<br> >>><br> >>> Yeah, I'm seeing this as well.=C2=A0 Admittedly, the whole= commit looks<br> >>> dubious to me, with all these out-of-blue new files and gratui= tous<br> >>> changes.=C2=A0 I guess sunpoet@ should revert it and merge onl= y needed<br> >>> parts thereof properly.<br> <br> Nope.<br> This commit unmasked the real problem of using autocrap tools to build<br> zstd -- a broken static library.<br> Issue was not raised before 'cause cmake configs was absent and qt6<br> (and may be other consumers) hooks up only shared lib.<br></blockquote><div= ><br></div><div>It should be fixed in ports 454e3c91ae9105a9af1939c96324240= 83ed3bbdb.</div><div>I've tested unmodified devel/qt6-base and it build= s fine.</div><div><br></div><blockquote class=3D"gmail_quote" style=3D"marg= in:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1e= x"> <br> Just to be clear -- I have a version of port converted to pure cmake build = and<br> it produce a valid static library which correctly liked by any consumer.<br= > <br> Anyway, number of consumers which require cmake'd zstd will grow in nea= r future.<br> openimageio/opencolorio/opnehadinglanguage are already require it to push<b= r> new versions to the ports tree.<br></blockquote><div><br></div><div>Please = let me know if more ports are broken.</div><div>=C2=A0</div><blockquote cla= ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex"> <br> >><br> >> I have only reported the issue as an early warning, as I said.<br> >><br> >> Regarding qt6-base a fix has already been proposed here by diizzy:= <br> >><br> >> <a href=3D"https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270= 664" rel=3D"noreferrer" target=3D"_blank">https://bugs.freebsd.org/bugzilla= /show_bug.cgi?id=3D270664</a><br> > <br> > Ah, good to know it's being taken care of, thanks for sharing!<br> <br> Nope. This patch not fixes anything but masking the real issue with broken<= br> libzstd.a by prefer dynamic library over static to link.<br> <br> <br> <br> -- <br> Sincerely,<br> Dima (fluffy@FreeBSD.org, <a href=3D"https://t.me/FluffyBSD" rel=3D"norefer= rer" target=3D"_blank">https://t.me/FluffyBSD</a>)<br>; (desktop, kde, x11, office, ports-secteam)@FreeBSD team<br> </blockquote></div></div> --000000000000c32ac905f8efe3fd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58SPsX5ZffMa8hkvgV36%2B-T1Dq%2BV80Yd5yymMz=sPRvnUQ>