Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 12 Feb 2011 15:19:18 +0100
From:      Alexander Leidinger <Alexander@Leidinger.net>
To:        Anonymous <swell.k@gmail.com>
Cc:        hackers@freebsd.org, kibab@freebsd.org
Subject:   Re: CFR: FEATURE macros for AUDIT/CAM/IPC/KTR/MAC/NFS/NTP/PMC/SYSV/...
Message-ID:  <20110212151918.00007489@unknown>
In-Reply-To: <86zkq27ci9.fsf@gmail.com>
References:  <20110211103028.12684f54yrw8tgqo@webmail.leidinger.net> <86zkq27ci9.fsf@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 11 Feb 2011 19:38:06 +0300 Anonymous <swell.k@gmail.com> wrote:

> Alexander Leidinger <Alexander@Leidinger.net> writes:
> 
> > Hi,
> >
> > during the last GSoC various FEATURE macros where added to the
> > system. Before committing them, I would like to get some review
> > (like if macro is in the correct file, and for those FEATURES where
> > the description was not taken from NOTES if the description is OK).
> >
> > If nobody complains, I would like to commit this in 1-2 weeks. If
> > you need more time to review, just tell me.
> [...]
> > Index: kern/kern_dtrace.c
> [...]
> > +FEATURE(kdtrace_hooks,
> > +    "Kernel DTrace hooks which are required to load DTrace kernel
> > modules"); +
> [...]
> > Index: kern/kern_lockstat.c
> [...]
> > +FEATURE(kdtrace_hooks, "Kernel DTRACE hooks");
> 
> Why description differs?

Good catch. I removed the second one completely in my working copy.

Bye,
Alexander.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110212151918.00007489>