Date: Tue, 17 Oct 2000 05:40:02 -0700 (PDT) From: Andre Albsmeier <andre.albsmeier@mchp.siemens.de> To: freebsd-bugs@FreeBSD.org Subject: Re: i386/22006: quotacheck halt Message-ID: <200010171240.FAA77134@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR i386/22006; it has been noted by GNATS.
From: Andre Albsmeier <andre.albsmeier@mchp.siemens.de>
To: Wei-Kai-Wu <wkwu@csie.nctu.edu.tw>
Cc: Andre Albsmeier <andre.albsmeier@mchp.siemens.de>,
FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: i386/22006: quotacheck halt
Date: Tue, 17 Oct 2000 14:28:13 +0200
On Tue, 17-Oct-2000 at 15:16:56 +0800, Wei-Kai-Wu wrote:
> On Mon, Oct 16, 2000 at 10:35:39AM +0200, Andre Albsmeier wrote:
> > What is the highest uid you have on /raid1 and /raid2 ?
> > You might want to look into PR #2325...
> > If this applies to your problem, I might have a patch for you.
>
> I have found that there are some files uid = -2.
> It cause quotacheck halt...
It doesn't halt. It just scans the quotacheck file from 0 to 2^32-1
and this takes a while. Do you use PC-NFS? That is how I got these
uid -2 files into my filesystems.
If you are interested, this my (real ugly) patch to solve this:
It maps all uids > 65535 to user nobody. I use it for many years
now and it works great... Don't know about security concerns.
--- sbin/quotacheck/quotacheck.c.ORI Mon Jul 31 09:20:54 2000
+++ sbin/quotacheck/quotacheck.c Mon Jul 31 09:21:15 2000
@@ -506,6 +506,8 @@
struct fileusage *fup, **fhp;
int len;
+ if( id > 65535 )
+ id = 65534;
if ((fup = lookup(id, type)) != NULL)
return (fup);
if (name)
--- sys/ufs/ufs/ufs_quota.c.ORI Mon Jul 31 09:36:03 2000
+++ sys/ufs/ufs/ufs_quota.c Mon Jul 31 09:36:44 2000
@@ -750,6 +750,8 @@
/*
* Check the cache first.
*/
+ if( id > 65535 )
+ id = 65534;
dqh = DQHASH(dqvp, id);
for (dq = dqh->lh_first; dq; dq = dq->dq_hash.le_next) {
if (dq->dq_id != id ||
>
> By the way, shall we take it as a bug?
It is a bug. It is covered by my PR.
-Andre
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010171240.FAA77134>