Date: Sun, 30 Dec 2018 18:18:53 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 234508] sysutils/grub2: Update to recent snapshot, fix build with GCC 8 Message-ID: <bug-234508-7788-m63hdzwOEQ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-234508-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-234508-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234508 Tobias Kortkamp <tobik@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-patch, needs-qa Summary|new port: sysutils/grub2 |sysutils/grub2: Update to |replacement |recent snapshot, fix build | |with GCC 8 Status|New |Open --- Comment #1 from Tobias Kortkamp <tobik@freebsd.org> --- Please make this a unified diff against the existing port. It's harder to see what you changed otherwise. It would also be good to base this on a recent revision (at least the changes and fixes from ports 484145 and ports r488585 appear to not be included here). X ${LOCALBASE}/bin/strip:devel/binutils \ X ${LOCALBASE}/bin/gcc8:lang/gcc8 These changes are wrong and ignore GCC_DEFAULT and other settings. Please use USE_GCC. If it doesn't need gcc at runtime, add RUN_DEPENDS:=3D ${RUN_DEPENDS:Ngcc*} after .include <bsd.port.mk> X ${LOCALBASE}/bin/python:lang/python Depending on the lang/python is forbidden by policy. People went through great pains to remove it from all ports, use BINARY_ALIAS=3D python=3D${PYTHON_CMD} if the build calls python directly. XICONV_PREFIX=3D ${LOCALBASE} ICONV_PREFIX is not a port settable variable and should only be set by the framework. It also already set by USES=3Diconv XMAKE_CMD=3D ${LOCALBASE}/bin/gmake Already set by USES=3Dgmake X# Created by: bergerkos@yahoo.co.uk Please retain the original "Created by" line. You did not create this port, sem@ did. You'll get full credit for the update in the commit log. Xpre-configure: X @cd ${WRKSRC} && ${SH} autogen.sh X Why does USES=3Dautoreconf no longer suffice? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234508-7788-m63hdzwOEQ>