Date: Tue, 27 Mar 2001 12:40:11 -0800 (PST) From: Archie Cobbs <archie@dellroad.org> To: Mike Tancsa <mike@sentex.net> Cc: freebsd-stable@freebsd.org, freebsd-net@freebsd.org, luigi@freebsd.org Subject: Re: Kernel Panic on 4.3-RC #0 using PPPoE Message-ID: <200103272040.f2RKeBn44013@arch20m.dellroad.org> In-Reply-To: <4.2.2.20010327070955.01db1268@192.168.0.12> "from Mike Tancsa at Mar 27, 2001 07:12:17 am"
next in thread | previous in thread | raw e-mail | index | archive | help
Mike Tancsa writes: > >Not sure why this hasn't been detected before though. Below is > >a possible patch. > > It has been at http://www.freebsd.org/cgi/query-pr.cgi?pr=25478 and > discussed a few times in freebsd-net. Here is the better (?) patch. I'd like to commit this if nobody objects.. Luigi: would you mind reviewing this for possible BRIDGE problems? -Archie __________________________________________________________________________ Archie Cobbs * Packet Design * http://www.packetdesign.com Index: if_ethersubr.c =================================================================== RCS file: /home/ncvs/src/sys/net/if_ethersubr.c,v retrieving revision 1.70.2.15 diff -u -r1.70.2.15 if_ethersubr.c --- if_ethersubr.c 2001/03/13 22:00:32 1.70.2.15 +++ if_ethersubr.c 2001/03/27 20:39:38 @@ -366,6 +366,11 @@ { int s, error = 0; + if ((ifp->if_flags & (IFF_UP|IFF_RUNNING)) != (IFF_UP|IFF_RUNNING)) { + m_freem(m); + return (ENETDOWN); + } + #ifdef BRIDGE if (do_bridge && BDG_USED(ifp) ) { struct ether_header *eh; /* a ptr suffices */ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103272040.f2RKeBn44013>