Date: Wed, 16 May 2007 11:28:54 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Dag-Erling =?utf-8?b?U23Dg8K4cmdyYXY=?= <des@des.no> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 Message-ID: <20070516112854.wz570hty7kss48sc@webmail.leidinger.net> In-Reply-To: <86zm45goph.fsf@dwp.des.no> References: <200705131815.l4DIFop9026874@repoman.freebsd.org> <20070514154040.0lofzrgm8kskgog4@webmail.leidinger.net> <86wszbqxbz.fsf@dwp.des.no> <20070514172938.5v4yi78kisokk84s@webmail.leidinger.net> <861whiy5ra.fsf@dwp.des.no> <20070516094330.dkp2e41vdc0w8kg8@webmail.leidinger.net> <86zm45goph.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Dag-Erling Sm=C3=83=C2=B8rgrav <des@des.no> (from Wed, 16 May 2007 =
=20
10:25:14 +0200):
> Alexander Leidinger <Alexander@Leidinger.net> writes:
>> Dag-Erling Sm=C3=B8rgrav <des@des.no> writes:
>> > Alexander Leidinger <Alexander@Leidinger.net> writes:
>> > > The original code hat it before, but you CD into DESTDIR, so it is no=
t
>> > > necessary anymore.
>> > Unless someone goofs and adds an absolute path to ObsoleteFiles.inc...
>> > which is why I very deliberately left "${DESTDIR}/" in front of the pat=
h
>> > in the rm command, although I could probably replace it with "./".
>> That would make it more consistent.
>
> No, wait, there is another reason I had forgotten: the path passed to rm
> is shown to the user, so it should be the full path.
Ah, yes... ok, why not remove the cd DESTDIR and use DESTDIR instead =20
of the ./? Or add a comment explaining why DESTDIR is used for the rm.
Bye,
Alexander.
--=20
Bombeck's Rule of Medicine:
=09Never go to a doctor whose office plants have died.
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070516112854.wz570hty7kss48sc>